feat: add TUI diagnostics and practical operations docs#3
Merged
Conversation
DF-wu
commented
Jul 17, 2026
DF-wu
left a comment
Owner
Author
There was a problem hiding this comment.
Self-review completed: no blocking findings after checking all 12 changed files. Safety-critical paths are covered by tests for fail-safe behavior, stale-loop health detection, credential redaction, monotonic fan curves, reserved placeholder targets, and emergency restore bypassing unrelated curve errors. GitHub CI is green, ShellCheck passes at warning level, Compose renders, and the Ubuntu image builds successfully. Residual verification is hardware-specific: run the new read-only diagnose, then controlled manual/restore checks on the target Dell/iDRAC before unattended auto mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.envupdates and redacted reviewconfig, read-onlydiagnose, log freshnesshealthcheck, DEBUG logging, source diagnostics, and safer validationrestoreusable even when unrelated fan-curve values are malformed./secretsread-only for ComposeVerification
make test(37 core assertions + 10 TUI assertions)-S warning)make validate-exampledocker compose configdocker build --build-arg BASE_IMAGE=ubuntu:24.04 -t idrac-fan-control:test .validate,config, and dry-runmanualReview notes
Real iDRAC, ESXi, and GPU connectivity still requires the target management network; the new
diagnosecommand is the read-only gate for that hardware verification. The repository.envremains placeholder data and was not changed.