-
-
Notifications
You must be signed in to change notification settings - Fork 456
Update streaminghub/getting-started.md #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| room.All.OnLeave(userName); | ||
| await room.RemoveAsync(Context); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought RemoveAsync should be called first here, but I left it as is.
By the way, in the implementation of samples/ChatApp, RemoveAsync is called first.
MagicOnion/samples/ChatApp/ChatApp.Server/ChatHub.cs
Lines 40 to 41 in e79d6de
| await this.room.RemoveAsync(this.Context); | |
| this.room.All.OnLeave(this.myName); |
|
Thank you for the PR!
|
|
Thank you for the confirmation. I agree that the suggested name is more intuitive and easier to understand. However, if we change the name, I believe the sample implementation should also be revised accordingly. What are your thoughts on this approach? |
|
Ah, I see. I hadn't considered this article and ChatApp to be the same thing. |
I see. That said, I personally believe there’s no downside to keeping interface definitions consistent. |
3a68b32 to
11e5d9a
Compare
|
I’ve made the fix. |
|
Thanks! |
Co-authored-by: mayuki <[email protected]>
…docs Sync PR #990 fix to Japanese and Korean documentation
I thought some parts of streaminghub/getting-started.md could be incorrect, so I made some adjustments.