Skip to content

Conversation

@jmolinasoler
Copy link

TLDR: Added and tested podman and docker functionality.

This pull request introduces comprehensive containerization support for safe-hash, enabling secure execution via Podman and Docker. It adds a multi-stage Dockerfile, container build and run scripts, documentation, and updates to the README to guide users on using containers for improved isolation and security. The changes also clarify the trust model when running in containers and provide best practices for secure usage.

Containerization and Security Enhancements

  • Added a multi-stage Dockerfile to build and package safe-hash with security best practices, including a minimal runtime, non-root user, and read-only filesystem.
  • Added .dockerignore to exclude build, test, editor, and OS-specific files from container images, reducing image size and attack surface.

User Experience and Documentation

  • Added scripts/podman-build.sh for building the container image, and scripts/safe-hash-rs for running safe-hash in a secure Podman container with options for interactive mode and volume mounts. [1] [2]
  • Added docs/PODMAN.md with detailed instructions, security features, troubleshooting, and integration examples for using Podman and Docker with safe-hash.
  • Updated README.md to document container usage, security features, quick start commands, and trust assumptions when running in containers. [1] [2] [3]

These changes provide a secure, isolated environment for running safe-hash, making it safer to verify Safe Wallet transactions and messages on potentially compromised systems.

@TilakMaddy
Copy link
Contributor

Thanks, I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants