Skip to content

Conversation

anthonyharrison
Copy link

@anthonyharrison anthonyharrison commented Feb 22, 2025

As discussed in ticket #595 this PR adds TLP marking to the metadata to indicate the sharing and distribution constraints for the BOM.

fixes #595

@anthonyharrison anthonyharrison requested a review from a team as a code owner February 22, 2025 12:52
@jkowalleck
Copy link
Member

jkowalleck commented Feb 22, 2025

thanks for the implementation, @anthonyharrison

Could you port these changes to schema 1.7 based on branch 1.7-dev?
Could I ask you to add some test data? they wold to into the folder tools/src/test/resources/1.7.

thank you in advance.

PS: i am sorry that i did not communicate these things earlier. Please bear with me.

@jkowalleck
Copy link
Member

I'll set this PR to "draft", until the proposed changes were ported to the "next" version.

@jkowalleck jkowalleck marked this pull request as draft February 22, 2025 15:18
Copy link
Member

@jkowalleck jkowalleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please port to "next" version.
v1.6 will not get any new features, but upcoming v1.7 will.

@anthonyharrison anthonyharrison closed this by deleting the head repository Feb 22, 2025
jkowalleck added a commit that referenced this pull request Jun 5, 2025
As discussed in ticket #595, this PR adds TLP marking in the BOM
metadata.

This PR superseeds #603

fixes #595
@prabhu
Copy link
Contributor

prabhu commented Jun 14, 2025

This is resulting in a string attribute called "distribution" under metadata and the phrase "tlp" is no where to be found.

{
 "metadata": {
    "timestamp": "2025-06-14T10:45:57Z",
    "tools": {
      "components": [
        {
          "group": "@cyclonedx",
          "name": "cdxgen",
          "version": "11.4.0",
          "purl": "pkg:npm/%40cyclonedx/[email protected]",
          "type": "application",
          "bom-ref": "pkg:npm/@cyclonedx/[email protected]",
          "publisher": "OWASP Foundation",
          "authors": [
            {
              "name": "OWASP Foundation"
            }
          ]
        }
      ]
    },
    "authors": [
      {
        "name": "OWASP Foundation"
      }
    ],
    "lifecycles": [
      {
        "phase": "build"
      }
    ],
    "distribution": "AMBER"
 }
}

Can we make distribution an object with an attribute tlpClassification, since the string attribute is confusing especially with externalReferences.type = distribution (Direct or repository download location).

@jkowalleck
Copy link
Member

@CycloneDX/core-team, what do you think about #603 (comment) ?

@jkowalleck
Copy link
Member

jkowalleck commented Jun 16, 2025

re: #603 (comment)
I'll draft a PR to showcase this.

PS: see the draft: #653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Include TLP marking in metadata
3 participants