move model.bom.Bom.validate() to validation.models #455

Activity

1. jkowalleck

   added

   breaking change

   on Sep 25, 2023
2. jkowalleck

   added this to the 5.0.0 milestone on Sep 25, 2023
3. jkowalleck

   linked a pull request that will close this issue[IDEA] refactor: model validator #456on Sep 26, 2023
4. jkowalleck

   added

   idea

   on Oct 10, 2023
5. jkowalleck

   removed this from the 5.0.0 milestone on Oct 11, 2023
6. jkowalleck

   changed the title [-][IDEA] move `model.bom.Bom.validate()` to `validation.models`[/-] [+]move `model.bom.Bom.validate()` to `validation.models`[/+] on Sep 16, 2024
7. jkowalleck

   added this to the 8.0.0 milestone on Sep 16, 2024
8. jkowalleck

   removed

   idea

   on Sep 16, 2024
9. jkowalleck

   assigned

   jkowalleck

   and unassigned

   jkowalleck

   on Sep 16, 2024
10. jkowalleck

    removed this from the 8.0.0 milestone on Sep 17, 2024
11. jkowalleck

    added

    help wantedExtra attention is neededExtra attention is needed

    on Sep 17, 2024
12. saquibsaifee commented on Jan 30, 2026

    

    saquibsaifee

    on Jan 30, 2026

    Contributor

    More actions

    This is just moving Bom.validate() to validation.model as-is and update the references, or do you want it refactored into smaller functions?
13. jkowalleck commented on Feb 6, 2026

    

    jkowalleck

    on Feb 6, 2026

    MemberAuthor

    More actions

    This is just moving Bom.validate() to validation.model as-is and update the references, or do you want it refactored into smaller functions?

    existing public API shall be deprecated and something more advanced shall be provided.
    details may be discussed
14. saquibsaifee commented on Feb 15, 2026

    

    saquibsaifee

    on Feb 15, 2026

    Contributor

    More actions

    Opened a draft to get something going on.

    I've implemented a ModelValidator that returns an iterable of errors (so you can collect multiple issues instead of failing on the first one). It's side-effect free - just validates, doesn't mutate anything.

    @jkowalleck I noticed Bom.validate() was marked "deprecated without replacement," but it does two things - normalization (
    register_dependency calls) AND validation. For backward compatibility, I kept both in the deprecated method. The new ModelValidator only validates. How do you want to handle this going forward?

    1. Keep the current approach (normalization stays in deprecated Bom.validate())
    2. Remove it completely (breaking change) and make validation optional with a parameter
15. saquibsaifee commented on Feb 15, 2026

    

    saquibsaifee

    on Feb 15, 2026

    Contributor

    More actions

    Do you already have some ideas about advance impelementation?

    1. Schema-based
    2. Multi-mode (strict, unstrict)
    3. Severity level
16. jkowalleck

    linked a pull request that will close this issuefeat!: implement ModelValidator and remove Bom.validate() #935on Apr 30, 2026