Mitigate large folder freeze during gallery startup#911
Open
ByteMedic wants to merge 11 commits intoCyberTimon:mainfrom
Open
Mitigate large folder freeze during gallery startup#911ByteMedic wants to merge 11 commits intoCyberTimon:mainfrom
ByteMedic wants to merge 11 commits intoCyberTimon:mainfrom
Conversation
Owner
|
Hey @ByteMedic, thanks for putting this together! I like several of the changes here and would love to keep them:
Also, can we can remove the logic that checks whether images have non-visible adjustment changes. Looking through it, it adds a fair amount of complexity and feels prone to subtle maintenance bugs. Overall, could we try to strike a better balance between the speedup gains and the complexity being introduced? Thanks again for the effort here! Timon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the branch work done to mitigate severe freezes that occurred when opening photo folders, especially with mixed RAW and large JPEG content.
What changed
Notes
A branch summary was added in
README.bytemedic-fix-large-folder-freeze.mdto document the work commit by commit.