Skip to content

refactor: use activityRelations for affiliations, merges, and others #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 16, 2025
Merged

refactor: use activityRelations for affiliations, merges, and others #3111

merged 24 commits into from
Jul 16, 2025

Conversation

skwowet
Copy link
Member

@skwowet skwowet commented May 26, 2025

No description provided.

@skwowet skwowet changed the title chore: attach debugger logs to understand deeper refactor: use activityRelations in member affiliations update May 26, 2025
@skwowet skwowet changed the title refactor: use activityRelations in member affiliations update refactor: use activityRelations in affiliations and merges Jun 3, 2025
@skwowet skwowet self-assigned this Jun 23, 2025
@joanagmaia
Copy link
Contributor

@skwowet I believe there is one place that we will also have to update:

  • When we process an incoming activity, we check the existing memberId from the activities table. Since we will stop updating these in activities, we should update that method to start reading the memberId from activityRelations.
    Probably better to sync with @themarolt on this one, and make sure that there isn't anywhere else that we need to update.

@skwowet
Copy link
Member Author

skwowet commented Jun 30, 2025

@joanagmaia Thanks for the heads-up! 👍

I’ll refactor it to read from activityRelations and double-check with @themarolt as well.

@skwowet skwowet changed the title refactor: use activityRelations in affiliations and merges refactor: read from activityRelations instead of activities for memberId and organizationId Jul 4, 2025
@skwowet skwowet changed the title refactor: read from activityRelations instead of activities for memberId and organizationId refactor: use activityRelations for affiliations, merges, and member/org reads Jul 4, 2025
@skwowet skwowet changed the title refactor: use activityRelations for affiliations, merges, and member/org reads refactor: use activityRelations for affiliations, merges, and lookups Jul 4, 2025
@skwowet skwowet marked this pull request as ready for review July 8, 2025 15:02
@skwowet skwowet requested a review from epipav July 9, 2025 15:51
@skwowet skwowet requested a review from themarolt July 14, 2025 09:40
themarolt
themarolt reviewed Jul 14, 2025
View reviewed changes
@skwowet skwowet changed the title refactor: use activityRelations for affiliations, merges, and lookups refactor: use activityRelations for affiliations, merges, and others Jul 16, 2025
@skwowet skwowet merged commit a86bbc4 into main Jul 16, 2025
11 checks passed
@skwowet skwowet deleted the improve/CM-2310 branch July 16, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarolt themarolt themarolt approved these changes

@epipav epipav Awaiting requested review from epipav

Assignees

@skwowet skwowet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skwowet @joanagmaia @themarolt