Skip to content

Compatibility fix for php 8.3 [PR FOR REVIEW ONLY DO NOT MERGE] #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: symfony-5-clean
Choose a base branch
from
Open

Compatibility fix for php 8.3 [PR FOR REVIEW ONLY DO NOT MERGE] #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
018fc2a
Compatibilty fix for php 8.3
NikitaRynkevich May 13, 2025
23ad629
Hotfix to return type
NikitaRynkevich Jun 9, 2025
10510a7
Fix for the dynamic property creation
NikitaRynkevich Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion DataTable/Table/AbstractTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ abstract class AbstractTable
*/
protected $layout;

public $formatter;

public $tableId;

/**
* @param FormFactory $formFactory
* @param Router $router
Expand Down Expand Up @@ -130,7 +134,7 @@ abstract public function getUnfilteredCount();
*/
abstract public function getFilteredCount();

private final function setDefaultOptions(OptionsResolver $resolver)
private function setDefaultOptions(OptionsResolver $resolver)
{
$resolver->setDefaults([
'layout' => $this->layout,
Expand Down
2 changes: 1 addition & 1 deletion Twig/DataTableExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public function __construct(TwigRenderer $renderer)
/**
* {@inheritdoc}
*/
public function getFunctions()
public function getFunctions(): array
{
return [
new TwigFunction('render_table', [$this, 'renderTable'], [
Expand Down