Skip to content

Conversation

slin-o
Copy link

@slin-o slin-o commented Jul 24, 2025

added new behavior that acts like ScrollOptionBehavior that stores values per side instead of for the enttire block

added new constructor to AllIcons to create custom icons with your own icon texture

@VoidLeech VoidLeech added pr type: fix PR fixes a bug pr type: feature PR adds a new feature or changes an existing feature pr status: wrong target PR is targeting the wrong branch labels Aug 6, 2025
@VoidLeech
Copy link
Collaborator

Is the AllIcons change related to the scrolloptionbehaviour? That might be better in a separate PR if not.

Copy link
Contributor

github-actions bot commented Aug 6, 2025

@slin-o, this pull request is targeting the wrong branch. Pull requests should target the branch corresponding to the earliest supported Minecraft version unless the changes are specific to code that only exists for a newer Minecraft version. Please change the target branch, resolve any merge conflicts, and leave a message here so we can continue with the process of reviewing and merging this pull request. Thanks!

@slin-o
Copy link
Author

slin-o commented Aug 6, 2025

Is the AllIcons change related to the scrolloptionbehaviour? That might be better in a separate PR if not.

the ScrollOptionBehavior needs an INamedIcons enum wich requires an AllIcons to be returned in one method to render the correct selection

@slin-o
Copy link
Author

slin-o commented Aug 6, 2025

why is this the wrong target @VoidLeech

@VoidLeech
Copy link
Collaborator

The earliest supported version atm is 1.20.1

@slin-o
Copy link
Author

slin-o commented Aug 6, 2025

ok

@slin-o slin-o changed the base branch from mc1.21.1/dev to mc1.20.1/dev August 7, 2025 06:48
@slin-o slin-o changed the base branch from mc1.20.1/dev to mc1.21.1/dev August 7, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr status: wrong target PR is targeting the wrong branch pr type: feature PR adds a new feature or changes an existing feature pr type: fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants