Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable factory gauge request timer #7593

Conversation

msbc1999
Copy link
Contributor

@msbc1999 msbc1999 commented Mar 2, 2025

This PR introduces a new logistics server configuration for factory gauges, enabling users to customize the request interval instead of using the previously hardcoded value of 100 ticks.

Additionally, it refactors the Math.min logic in the NBT read method to prevent configuration read spam.

@msbc1999
Copy link
Contributor Author

msbc1999 commented Mar 3, 2025

I reverted the Math.min logic from the NBT read back to its original method because the gauge timer needs to reset naturally for the new configuration to take effect. This is especially noticeable when changing from a long interval to a shorter one, as a world/server reload may be required if the previous interval was extremely long.

I'm not sure if reading the configuration every tick will overwhelm the logic, but I'll leave it this way for now.

@simibubi simibubi merged commit d1edb07 into Creators-of-Create:mc1.20.1/dev Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants