Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CC:Tweaked setSchedule entries order #5973

Closed
wants to merge 1 commit into from
Closed

Fix CC:Tweaked setSchedule entries order #5973

wants to merge 1 commit into from

Conversation

AstralJaeger
Copy link

  • make sure only valid schedules are passed to setSchedule
  • use standard for loop instead of iterator to guarantee table order

Closes #5964
Fixes #5818

@AstralJaeger
validate schedules and fix oder
1ce5900 
+ make sure only valid schedules are passed to setSchedule
+ use standard for loop instead of iterator to guarantee table order
@AstralJaeger
Copy link
Author

@simibubi @Jozufozu would be nice if you could have a look 🙏

@IThundxr IThundxr added pr type: fix PR fixes a bug pr flag: simple PR has minimal changes labels Mar 5, 2024
IThundxr
IThundxr requested changes Jul 11, 2024
View reviewed changes
Copy link
Member

@IThundxr IThundxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should target 1.18/dev

@IThundxr IThundxr added the pr status: waiting for author PR cannot progress until author makes requested changes label Jul 11, 2024
simibubi added a commit that referenced this pull request Jul 25, 2024
@simibubi
Fix CC:Tweaked setSchedule entries order
c013173 
- Port of #5973 to 1.18
@simibubi
Copy link
Collaborator

Thanks for the PR
This has been implemented on the main branch and will be ported to newer mc versions internally

@simibubi simibubi closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IThundxr IThundxr IThundxr requested changes

@svemat01 svemat01 svemat01 approved these changes

Assignees
No one assigned
Labels
pr flag: simple PR has minimal changes pr status: waiting for author PR cannot progress until author makes requested changes pr type: fix PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AstralJaeger @simibubi @svemat01 @IThundxr