Fix custom to fully support Codable protocol when using SwiftData #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes certain crashes when using NaiveDate/Time with SwiftData.
t-p-dev
changed the title
|
Hi @kean and @liamnichols! Any chance of getting this merged in? This fixes some intermittent crashes we encountered when persisting NaiveDate objects with SwiftData. 🙏 |
kean
requested changes
Aug 10, 2024
| } | ||
|
|
||
| public func encode(to encoder: Encoder) throws { | ||
| try _encode(self, to: encoder) | ||
| if String(describing: encoder) == "SwiftData.CompositeEncoder" { |
There was a problem hiding this comment.
Is there a way to implement it without hardcoding "SwiftData.CompositeEncoder"?
There was a problem hiding this comment.
Good question, I didn't have a time to find a way just yet
|
Hey, sure, let me look into it. Do you what's the root cause of the crash? |
|
Is this really needed? Wouldn’t it make more sense to make the NaiveDate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes certain crashes when using NaiveDate/Time with SwiftData.