EE/CC #69
EE/CC #69
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Wojtach, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request delivers a comprehensive solution for managing Couchbase Lite editions (Community vs. Enterprise) within React Native and Expo applications. It provides a user-friendly command-line interface and an Expo plugin to automate the complex native dependency configuration, ensuring the correct Couchbase Lite library is used based on the developer's chosen edition, and persists this choice for seamless development.
Highlights
- Edition Configuration Tool: Introduced a new command-line tool (
npx cbl-reactnative-configure) that allows users to easily switch between the Community Edition (CE) and Enterprise Edition (EE) of Couchbase Lite for their React Native and Expo projects. - Expo Plugin for Native Configuration: Implemented an Expo plugin (
cbl-reactnative) that automatically configures the native Android (Gradle) and iOS (CocoaPods) dependencies to link the correct Couchbase Lite library based on the selected edition, simplifying setup for Expo users. - Edition Persistence: Added a
cbl-edition.jsonfile to persist the chosen Couchbase Lite edition across builds andprebuild --cleanoperations, ensuring the configuration remains consistent. - Native Code Adaptations: Modified Android native code to use reflection for setting certain Enterprise-specific properties (like
acceptOnlySelfSignedServerCertificate), allowing for conditional feature gating based on the active edition. - Documentation and Scripting: Updated the
README.mdwith clear instructions for using the new configuration tool and added correspondingbinentries and npm scripts inpackage.jsonfor easier management.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to switch between Community and Enterprise editions of Couchbase Lite. It adds a new script cbl-reactnative-configure and an Expo plugin to manage the native dependencies for Android and iOS based on the selected edition. The changes are well-structured and address the goal of edition-gating. My feedback focuses on improving maintainability by centralizing a hardcoded version string and fixing a minor formatting issue in the documentation.
| Our support portal is unable to assist with requests related to this project, so we kindly ask that all inquiries stay within GitHub. | ||
|
|
||
| Your collaboration helps us all move forward together — thank you! | ||
| ``` |
There was a problem hiding this comment.
The file ends with a dangling code block fence (```). This will likely cause markdown rendering issues and should be removed.
| }, | ||
| }; | ||
|
|
||
| const VERSION = '3.2.1'; |
There was a problem hiding this comment.
The Couchbase Lite version is hardcoded here as 3.2.1. This same version is also hardcoded in scripts/configure-edition.js (line 69). To improve maintainability and reduce the risk of inconsistencies when updating the dependency version, consider defining this version in a single, shared location.
Gating features in native submodule works. (first commit)
Script is not working. (could mess features gating)
Script should allow users to change between EE and CE versions.
Commands:
npx cbl-reactnative-configure EE- Switch to Enterprisenpx cbl-reactnative-configure CE- Switch to CommunityVersion set should persist after prebuild --clean
Should work for both expo and react native
Can be changed after instalation.
Interface should be handled by env variable. CE interface should be conditionally extended by EE methods and properties.