Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: engine can intialize with app NativeEventEmitter #36

Merged
merged 1 commit into from
Apr 1, 2025
Merged

fix: engine can intialize with app NativeEventEmitter #36

merged 1 commit into from
Apr 1, 2025

Conversation

Wojtach
Copy link

@Wojtach Wojtach commented Mar 7, 2025 •
edited
Loading

@azaddhirajkumar azaddhirajkumar self-requested a review March 21, 2025 13:00
azaddhirajkumar
azaddhirajkumar reviewed Mar 21, 2025
View reviewed changes
Copy link
Contributor

@azaddhirajkumar azaddhirajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we making sure that all the tests pass with this change?

@Wojtach
Copy link
Author

Wojtach commented Mar 24, 2025

Double checked, there is no regression in existing tests.

@azaddhirajkumar azaddhirajkumar merged commit 6c08c8f into Couchbase-Ecosystem:main Apr 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azaddhirajkumar azaddhirajkumar azaddhirajkumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wojtach @azaddhirajkumar