-
Notifications
You must be signed in to change notification settings - Fork 1
Use const generics #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6fb86a
to
092558e
Compare
092558e
to
52f714e
Compare
c17ca93
to
17d590f
Compare
17d590f
to
bd462e9
Compare
99ff87b
to
e71d586
Compare
e71d586
to
b09b3dd
Compare
1d67232
to
6f35a5b
Compare
70143e0
to
295cf44
Compare
295cf44
to
6cc99e6
Compare
heavenboy8
reviewed
Sep 19, 2022
ThibsG
reviewed
Sep 19, 2022
afaee4c
to
3e92015
Compare
3e92015
to
fe1a25e
Compare
BREAKING CHANGE: implementations should use a SHA algorithm (preferentially SHA-3 since Intel processors will include dedicated NI in the long run) if the input has enough entropy, Argon2 or a PBKDF otherwise (see ANSSI specification about this).
Fix typos, increase homogeneity and add inline proc macros when possible.
ThibsG
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KEY_LENGTH
had to be added to theDem
trait to be able to use{ Aes256GcmCrypto::KEY_LENGTH }
as a constant genericSymmetricCrypto
trait ->Dem
becomes the default trait for symmetric encryptionDhKeyPair
trait, which represent an asymmetric key pair based on a space where the computational Diffie-Helman is intractableblock.rs
: checking the plaintext/ciphertext size to prevent nonce reuse should be done in the DEM implementation as it is specific to nonce-based symmetric ciphers; block structure is pushed up onto the call stack through the use of associated dataNonceTrait::increment()
withoutBigInt
dependency and removebig-int
from the crate dependenciesstd
wherecore
can be usedstd
is needed is inaes_256_gcm_pure.rs
aes-gcm
with theno-alloc
featureEdit: there still is a
std
dependency as arand_core
featureEdit: after discussion with @bgrieder I removed
increment()
from the nonce trait