Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #1470

wants to merge 1 commit into from

Conversation

krenax
Copy link

@krenax krenax commented Jan 24, 2025

No description provided.

Copy link

vercel bot commented Jan 24, 2025

@krenax is attempting to deploy a commit to the Corentin Thomasset's Team Team on Vercel.

A member of the Team first needs to authorize it.

ports:
- 8080:80
image: corentinth/it-tools:latest
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going beyond "just adding docker-compose", I would dare suggesting adding the ability to force the container to stay local. Prevent egress. This way, there is one more control saying for example that the code that checks for password strength will not do funny things with said password.

Something like this:

services:
  it-tools:
    image: corentinth/it-tools:latest
    ports:
      - "127.0.0.1:8080:80"
    networks:
      it-tools:
networks:
  it-tools:
    internal: true

At least text-diff and mac-address-lookup seem to break in this environment. I have not checked the code to see why, but I imagine some outgoing connection attempt is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants