Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/server/page-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ export class PageService {
name: page.title,
}),
);
// The page may have been deleted while Intelligence created its thread.
// Recheck before binding a local conversation or marking it ready.
this.workspace.pages.get(spaceId, pageId);
if (!this.workspace.canAccessSpace(dotId, spaceId))
throw new PageError('Space access has been revoked.');
const thread =
Expand Down
37 changes: 37 additions & 0 deletions tests/page-conversation-deletion.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import { expect, it, vi } from 'vitest';
import { WorkspaceStore } from '../src/server/workspace.js';
import { PageService } from '../src/server/page-service.js';

it('does not bind a conversation when its page is deleted during thread creation', async () => {
const ws = new WorkspaceStore(':memory:', 'owner');
try {
const dot = ws.dots()[0];
const page = ws.pages.create(dot.spaceId, { title: 'Temporary' });
let resolve!: () => void;
const remote = new Promise<void>((done) => {
resolve = done;
});
const getOrCreateThread = vi.fn(() => remote);
const service = new PageService(ws, () => ({
getOrCreateThread,
getThreadMessages: async () => ({ messages: [] }),
}));
const pending = service.conversation(dot.spaceId, page.id, dot.id);
const outcome = expect(pending).rejects.toThrow(/Page not found/);
expect(getOrCreateThread).toHaveBeenCalledTimes(1);
ws.pages.delete(dot.spaceId, page.id);
resolve();
await outcome;
expect(ws.conversations()).toHaveLength(0);
expect(ws.pages.thread(page.id, dot.id)).toBeUndefined();
const replacement = ws.pages.create(dot.spaceId, { title: 'Replacement' });
const thread = await service.conversation(
dot.spaceId,
replacement.id,
dot.id,
);
expect(ws.pages.forThread(thread.id)?.id).toBe(replacement.id);
} finally {
ws.close();
}
});
Loading