Repository navigation
test(showcase): video 11, find the flags you can remove (#1889) - #2069
Merged
Merged
Conversation
Video 11's storyboard, its CLAIMS rows, the setup that makes its flags and dates them back, and gate 10's stale end state (S1 and S2 of the V11-V13 plan, with PE 3, 5, 6 and 8). Stage 1: no take has run. - Storyboard 11-stale-flags: the flag list on the demo seed, with four flags the setup makes off camera and dates back, said in the first caption. One beat per stale row, each saying the page's reason line; then Stale pressed, and the hint (the payoff), said in the page's words. The browser's zone and locale are pinned (the Updated column is toLocaleDateString). 15 sentences. - The kill switch's own beat is cut: the opening caption that would have said it was tagged permanent is refused on length (EMV11-6), and a test holds that refusal. The archive card is cut: the dashboard has no archive action. Both words are said only with the hint, which draws them, on screen. - setup.flags (S1): at most six, keys the API takes and the seed does not use, ages clear of 30 days, updated no earlier than created, and the end state derived at load from the flags' fields by the docs' table, held equal to the server's own classifier. At run time each flag is made in its state, one API key named showcase-setup is made (a needle, with its name), three flags are evaluated with it as X-API-Key (offcamera.send's new keyword-only api_key), all four are dated back in one transaction in the stack's own Postgres from checked keys and whole days only, read back within 10 minutes, and ?stale=true is judged before the first frame. - end_state.stale (S2): after the last frame, stale_days 30, ?stale=true exactly the three with their reasons, every other flag not stale, each setup flag's updated_at as the setup left it, and what the page drew: each row's pill and reason lines, the hint, the pills 3 and 3, the rows the API's total, no notice. A beat's new count reads the pills, rows and notice by CSS. Unset, stale is left out of the end state's dump. - test_showcase_dashboard_testids.py covers boards 9 and 11, the count selectors included (PE 8). CLAIMS_11 in test_showcase_quoted_docs.py. - VIDEOS registers 11 right after 5, so no pin on the order moves; the gains pin counts seven videos at the default until video 11's own gain is measured; the zone pins name videos 9 and 11. Closes #1889 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019CNVFcEPovQW1L3b1vWqGH Signed-off-by: amarkanday <a.markanday@gmail.com>
The narration-first review of video 11 (round 1, approve with changes) froze two lines as it worded them, and asked for the length check to count the cards. Every other say line and caption is unchanged. - Beat 3's caption is "An off flag left unchanged is stale too." (was "An off flag nobody changed is stale too."): the setup changes Holiday banner 50 days back, and the beat's own sentence says "its last change". Sentence 7's CLAIMS_11 row now also holds that the caption says "left unchanged". - Sentence 15 is "Listing the stale flags changes none of them." (was "Listing them changes no flag."): said right after "Tags are set through the API.", "them" read as the tags. Its CLAIMS_11 row is re-keyed; what it holds drawn and the pages it quotes are unchanged. - The length test projects with voiced.projected_ms, the capture's own projection, which counts the title and end cards: the 55 s floor and the cap are both on that length, so the card-less figure left the cap check 7 s loose. With video 9's fitted clip model: 71.9 s central, 76.6 s p90, against the 55 s floor and the 87.3 s cap. Refs #1889 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019CNVFcEPovQW1L3b1vWqGH Signed-off-by: amarkanday <a.markanday@gmail.com>
Brings video 11's board (stale flags) up to main 373744b. The merge itself was clean. One board test followed main: the stale-flags board's archive-card check read a dashboard test that said the dashboard has no archive action; main now offers Archive (#442, #1911), so the check reads that pin's new wording and the card stays cut. The storyboard's comment that said the dashboard has no archive action now says it has one and the card is cut by decision. The narration is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NpxPyav9uBxNuiXsDvD8qn Signed-off-by: amarkanday <a.markanday@gmail.com>
amarkanday
added a commit
that referenced
this pull request
Nov 20, 2026
Brings video 12 (balance within groups) up to main d7918c1, which merged video 11 (#2069). The same 5 files are touched by both videos; each keeps both videos' entries, nothing from either side is dropped: - tests/acceptance/showcase/capture/config.py: VIDEOS lists 05-plan-and-team, 12-balance-within, 11-stale-flags, then 06-shoplab-ab-test. - tests/acceptance/showcase/overrides.yaml: both entries, 11-stale-flags and 12-balance-within, each empty. - backend/tests/unit/showcase/test_showcase_dashboard_testids.py: BOARDS holds both boards (video 11: 7 ids, video 12: 23), both videos' sections stay, and the docstring names both. - backend/tests/unit/showcase/test_showcase_voice.py: the gains pin is now 8, since both videos take the default 4.5 dB; the comment says so. - backend/tests/unit/showcase/test_showcase_quoted_docs.py: both quoted-docs blocks (CLAIMS_11 and CLAIMS_12 with the card's key) and both docstring paragraphs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NpxPyav9uBxNuiXsDvD8qn Signed-off-by: amarkanday <a.markanday@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video 11, find the flags you can remove (#1889). Stage 1: the storyboard, its narration, its CLAIMS rows, the setup that makes and dates its flags (S1 of the V11-V13 plan) and gate 10's stale end state (S2). No take has run; the say lines are frozen as the narration-first review (round 1) left them.
What the video shows
One dashboard scene, the flag list, on the
demoseed. The departures, the sign-in and the setup, are both off camera and said in the first caption: "Signed in off camera. Four flags made off camera, dated weeks back." The demo seed and its counts are unchanged.permanent, no pill), then the three stale flags, each with its Stale pill and one reason line, then the seed's two flags (new, no pill).The browser's
time_zoneandlocaleare pinned (America/Los_Angeles, en-US): the Updated column istoLocaleDateString(PE 6).Cut, as the plan rules:
permanentandtagsare said only in the payoff beat, with the hint that draws them in frame.frontend/src/tests/pages/feature-flag-key-and-archive.test.tsx, which a test here checks is still there), but the card stays cut: this video does not show it.archivedis said only with the hint, which draws it, on screen.The say lines (15)
Sentences 5 and 7 say the page's reason lines word for word, and 9 says the page's line plus the guide's words ("while evaluations of other flags were") (
staleReasonText, N the API'sstale_days); 12-14 are the hint, split at its semicolon because a sentence is at most 12 words. Projection with video 9's fitted clip model (no Polly call), as the capture projects it (voiced.projected_ms, the title and end cards included): 71.9 s central, 76.6 s p90, of 90 s (refused above 87.3 s). The silent estimate is 33.1 s with the cards, under the 55 s floor: the silent take exits 1 with the length line alone (S5, EMV11-8), and nothing is padded.Changed at the narration review, round 1, in its words: beat 3's caption is "An off flag left unchanged is stale too." (was "An off flag nobody changed is stale too.": the setup changes Holiday banner 50 days back, and the beat's own sentence says "its last change"), and sentence 15 is "Listing the stale flags changes none of them." (was "Listing them changes no flag.", where "them" read as the tags). The length test now projects with the cards, as the floor and the cap are measured.
S1:
setup.flagsAt load: at most six flags, each
{name, key, status, rollout, tags, evaluate, created_days_ago, updated_days_ago}and nothing else (no rules, no schedule); a key the API takes ([a-z0-9][a-z0-9_-]{0,63}) and not one of the seed's (new_dashboard_ui,beta_features, held to the seed's source); updated no earlier than created; every age more than 15 days from N = 30; at least one flag evaluated; no flag namedstale. The end state is derived at load from those fields by the docs' table (derived_stale), and that derivation is held equal to the server's ownstale_flags.classifyover every combination a setup flag can declare.At run time (
run.make_flags), after gate 14, every call with its exact status:POST /api/v1/feature-flags/, 201) in its declared state: the create takesis_active,rollout_percentageandtags, so no PUT or toggle is sent; an answer that is not that flag refuses;POST /api/v1/api-keys, 201, no scope: the evaluate route takes any valid key,deps.get_api_key). Its name isshowcase-setup, which is also the evaluations'user_id; the key and that name are needles from then on, and gate 6 requires both;GET /api/v1/feature-flags/evaluate/{key}?user_id=showcase-setup, 200), throughoffcamera.send's new keyword-onlyapi_key=, which sendsX-API-Keyinstead ofAuthorization: Bearer(check fix 5); an answer for another flag or reason refuses;docker compose exec -T postgres psql, or the uvicorn stack's container): oneUPDATE experimentation.feature_flags SET created_at = (now() AT TIME ZONE 'UTC') - make_interval(days => c), updated_at = ... (u) WHERE key = 'k' RETURNING keyper flag, built only from a key matching the API's rule and two whole numbers from 0 to 3650, with-v ON_ERROR_STOP=1 --single-transaction -q -A -t; refused unless each statement returned its one row;GET /api/v1/feature-flags/{id}):created_atandupdated_atwithin 10 minutes of what was set, or refused (a key matching no row, a time zone slip);?stale=truejudged as gate 10 judges them (gates.stale_api): an evaluation the server failed to record (it swallows that failure) shows only here.S2: gate 10's
end_state.staleAfter the last frame, the list and
?stale=trueread again:stale_daysis 30 andevaluations_seentrue in both (aSTALE_FLAG_DAYSleak refuses, as does an answer without the fields);?stale=trueis exactly the three, each with its one reason, in the API's order;updated_atis what the setup read back: listing changes no flag (checked before the map, so a write is named as the cause);totaleach time (6, then 3), and the notice 0.A beat's new
countkeeps how many elements a CSS selector matches at its cue's start (director.count_beat); the rows and the hint are ordinaryrecordreadings. The load refuses a reading or count the end state names that no beat takes, a count named twice or as a reading, and the before/after readings taken anywhere but one beat each, in that order. Unset,staleis left out of the end state's dump, so every other video's gate 10storyboardnumber is as it was (video 3'sV3_DUMPpin).The board's cut waits for the hint and for the table without the kill switch's row, so the rows read with Stale pressed are the filtered list, not the one still on screen while it reloads.
The test ids (PE 8)
test_showcase_dashboard_testids.pycovers boards 9 and 11 (BOARDS, 65 and 7 ids), thecountselectors included. The Stale button is found by its role and name: its test id is built from a map at run time, which the resolver reads as a number.CLAIMS_11
One row per sentence in
test_showcase_quoted_docs.py; the pages aredocs/feature-flags/stale-flags.md(S),docs/capabilities.md(C) anddocs/getting-started/quick-start.md(Q).flags-table; the pill's markupflags-table; N fromdata.stale_daysflags-table,flag-rowdemoseed "(three experiments, two flags)"; S: "created at least N days ago"staleReasonTextflag-stale-reasons; caption; theon_for_everyonelineon_for_everyonerowflag-rowflag-stale-reasons; caption ("left unchanged"); theoff_for_everyonelineoff_for_everyonerowflag-row; the Updated column andformatDate(flag.updated_at)updated_at."; "every change to a flag sets it"flag-stale-reasons; caption; thenot_evaluatedlinenot_evaluatedrowflag-stale-reasonsflag-stale-filter; the Stale filter;stale: truesent only while pressed?stale=truelists only the stale flags"flag-stale-hint; caption; the hintflag-stale-hint; the hintpermanentis never stale."flag-stale-hint; the hintflags-table; the hintA test also holds the guide's reasons table (its rows, their order, the permanent rule, N's default) as the one the board derives from, so a docs-only change to it meets the board.
The copy check's pathspec, generated from CLAIMS_11 and the board's cards (none):
frontend/src ':!frontend/src/tests' docs/capabilities.md docs/feature-flags/stale-flags.md docs/getting-started/quick-start.md.Plants (each red, then restored; the tree equal to the commit after each)
?stale=truecheck before the first frame removed: the setup's drop-one-evaluate andSTALE_FLAG_DAYSplants pass, 2 FAILED.api_key=sending the Bearer token too: FAILED. The SQL key check removed: a quote, capitals, a space and an empty key reach the statement, 4 FAILED.updated_atcheck removed: a later write to a stale flag and a toggle of the kill switch pass, 2 FAILED. Thestale_dayscheck removed: an API atSTALE_FLAG_DAYS=1(which marks the same three) passes, 2 FAILED.permanent: the board itself is refused ("the docs' table gives {'payments-kill-switch': ['on_for_everyone'], ...}"), 76 FAILED.test_video_3s_end_state_dump_is_mainsand the every-other-board dump test FAILED.count_beatnot called in the beat: FAILED. The setup's needles not added to the redactor, and gate 10's stale block skipped: FAILED each.data-testid="flag-stale-pill"renamed in the flag list: the testids test FAILED namingflag-stale-pill(with the CLAIMS and words tests, 12 FAILED). The hint reworded: the words test and CLAIMS_11 FAILED.archiv(clean: 1).updated_atcheck and the dump's drop (7 FAILED).Rehearsed, not in CI
The dating step's exact statements and options, run against a scratch PostgreSQL 14 (server time zone America/Los_Angeles): psql printed the four keys, one a line, and nothing else; each flag was 120/120, 90/60, 75/50 and 60/50 days back, to the 1/10000 of a day; a key matching no row printed only the others; a failing statement in the same call rolled the transaction back (exit 1).
Other changes
VIDEOSregisters 11 right after 5 (no pin on the order moves). When video 12's pull request is also merged, 12 takes the place right after 5 (its own pin) and 11 follows it: this board's pin asks only for a place between 5 and 6.overrides.yaml11-stale-flags: {}.Runs
backend/tests/unit/showcase/plusbackend/tests/unit/infrastructure/test_docs_only_gate.py: 2029 passed, 0 failed, 0 skipped (exit 0; main: 1898);scripts/check_junit_skips.py: exit 0. The same suite in agit archive HEADcopy with no.git: 2029 passed.ruff checkandruff format --checkover the Makefile's lint scope: exit 0.gitleaks detect --log-opts=origin/main..HEAD: exit 0.scripts/leak_guard.py --range origin/main..HEAD: exit 0.Not verified
docker compose exec: rehearsed on PostgreSQL 14's psql over TCP only.make lint's other steps: no frontend file changes.Closes #1889
🤖 Generated with Claude Code
https://claude.ai/code/session_01NpxPyav9uBxNuiXsDvD8qn