-
Notifications
You must be signed in to change notification settings - Fork 1
Add a "Dataset Importer" Windmill app #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rudokemper
wants to merge
51
commits into
main
Choose a base branch
from
windmill-app-gc-file-uploader
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into windmill-app-gc-file-uploader
…into windmill-app-gc-file-uploader
…into windmill-app-gc-file-uploader
…into windmill-app-gc-file-uploader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Closes #117.
Screenshots
What I changed
f/apps/gc_dataset_importer.app
, which consists of:app.yaml
) built around the Stepper component to guide the user through uploading a dataset.data_conversion.py
andfile_operations.py
. I’ve added comments and additions to the docstrings to clarify why these changes were necessary.f/apps/gc_uploader.app
, which only supported Locus Map data.Notes to the reviewer
/apps/edit/f/apps/gc_dataset_importer
) and walk through the steps to see how scripts are called, how state is managed, etc.f/apps/gc_dataset_importer.app
, and any changes tof/common_logic
.f/apps/gc_dataset_importer.app
mainly call functions from imported modules, handle errors, and log outcomes. Any broader business logic that I felt could be useful to other code was added to the appropriate file inf/common_logic/
. There are nevertheless a few helper functions in the Python scripts in the app directory since they are highly specific to the app, so I did not think it was worth moving them intof/common_logic/
. Opinions on my choices are welcome.f/connectors/
code in this branch. I already filed those as separate PRs -- Add CSV to Postgres script #135 and Generate unique ID if not present in GeoJSON feature #136. After these are merged, I will rebase onmain
so that overlapping changes here are dropped.What I'm not doing here