46 fixecdata calltoc1membershipwcp #47
Conversation
|
|
|
|
pkg/precompiles.sty
Outdated
| \utt{Third argument (high):} & \col{\cmdECDATA@var@argThreeHi} \\ | ||
| \utt{Third argument (low):} & \col{\cmdECDATA@var@argThreeLo} \\ | ||
| \utt{Fourth argument (high):} & \col{\cmdECDATA@var@argFourHi} \\ | ||
| \utt{Fourth argument (low):} & \col{\cmdECDATA@var@argFourLo} \\ |
There was a problem hiding this comment.
I don't think we need the \col{...} stuff here, do we ? All you give it are local shorthands \locXxx which are already under \col{...}.
There was a problem hiding this comment.
Also it would be nice to have more expressive names for the arguments, e.g.
\utt{x coord. hi} & \col{\cmdECDATA@var@xHi} \\
\utt{x coord. lo} & \col{\cmdECDATA@var@xLo} \\
\utt{y coord. hi} & \col{\cmdECDATA@var@yHi} \\
\utt{y coord. lo} & \col{\cmdECDATA@var@yLo} \\
\utt{LHS of (E) hi} & \col{\cmdECDATA@var@ySquareHi} \\
\utt{LHS of (E) lo} & \col{\cmdECDATA@var@ySquareLo} \\
\utt{RHS of (E) hi} & \col{\cmdECDATA@var@xCubePlusThreeHi} \\
\utt{RHS of (E) lo} & \col{\cmdECDATA@var@xCubePlusThreeLo} \vspace{2mm} \\
\multicolumn{2}{l}{\utt{Where (E) is } y^2 = x^3 + 3} \\ % as an examplewith some explanation that the LHS and RHS refer to those of equation
pkg/precompiles.sty
Outdated
| \utt{Third argument (high):} & \col{\cmdECDATA@var@argThreeHi} \\ | ||
| \utt{Third argument (low):} & \col{\cmdECDATA@var@argThreeLo} \\ | ||
| \utt{Fourth argument (high):} & \col{\cmdECDATA@var@argFourHi} \\ | ||
| \utt{Fourth argument (low):} & \col{\cmdECDATA@var@argFourLo} \\ |
| argThreeHi = \locBYImHi , | ||
| argThreeLo = \locBYImLo , | ||
| argFourHi = \locBYReHi , | ||
| argFourLo = \locBYReLo , |
There was a problem hiding this comment.
Same issue here: arg1 etc .. aren't expressive enough. We need better keys.
| \utt{x coord. hi:} & #3 \\ | ||
| \utt{x coord. lo:} & #4 \\ | ||
| \utt{y coord. hi:} & #5 \\ | ||
| \utt{y coord. lo:} & #6 \\ |
There was a problem hiding this comment.
This should also be converted to the xkeyval package.
| yImLo = \locBYImLo , | ||
| yReHi = \locBYReHi , | ||
| yReLo = \locBYReLo , | ||
| } | ||
| \] | ||
|
|
||
| \[ |
There was a problem hiding this comment.
This space
\]
\[should be removed. There are better ways to create separation if this is the goal.
This reverts commit 0649956.
No description provided.