Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update limits for blockhash, blockdata and blake prc #133

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

letypequividelespoubelles
Copy link
Contributor

No description provided.

@letypequividelespoubelles letypequividelespoubelles linked an issue Jan 22, 2025 that may be closed by this pull request
Copy link

cla-assistant bot commented Jan 22, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ fab-10
❌ letypequividelespoubelles
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

cla-assistant bot commented Jan 22, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@letypequividelespoubelles
Copy link
Contributor Author

@fab-10 do we care about all acceptance-test/*/limits.toml ? It seems they contain old name's module, so not sure they are really used ...

@fab-10
Copy link
Contributor

fab-10 commented Jan 22, 2025

@letypequividelespoubelles they are used by the ATs, the important thing is that they contain the right module names, while for the limits they are made up to adapt to the specific tests.
Why are you making these changes?

@letypequividelespoubelles
Copy link
Contributor Author

@fab-10 There was a redesign of BLOCKDATAand BLOCKHASH, so I've updated the limits to accept the same number of module operations. BLAKEprecompile is not provable at the moment, so set the limit to 0.

@letypequividelespoubelles
Copy link
Contributor Author

@fab-10 PHONEY_RLPand TX_RLP doesn't exist anymore (it's old names for RLP_TXN, should we delete those lines then ?

@fab-10
Copy link
Contributor

fab-10 commented Jan 22, 2025

@fab-10 PHONEY_RLPand TX_RLP doesn't exist anymore (it's old names for RLP_TXN, should we delete those lines then ?

yes thanks.

@fab-10
Copy link
Contributor

fab-10 commented Jan 29, 2025

@letypequividelespoubelles you need to sign the CLA if you want this merged

@letypequividelespoubelles letypequividelespoubelles merged commit e5526cc into main Feb 7, 2025
6 of 7 checks passed
@letypequividelespoubelles letypequividelespoubelles deleted the 132-update-module-limits branch February 7, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update module limits
2 participants