-
Notifications
You must be signed in to change notification settings - Fork 38
COR-1515: Remove test infrastructure #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rasmus-kirk
wants to merge
14
commits into
main
Choose a base branch
from
remove-test-infrastructure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c7c029
to
1838119
Compare
69431b8
to
bbeb0a5
Compare
bbeb0a5
to
0e8117b
Compare
limemloh
reviewed
Jun 10, 2025
8c94bd8
to
897894c
Compare
897894c
to
2025dd9
Compare
c4cd37f
to
ccf8500
Compare
rasmus-kirk
commented
Jul 15, 2025
name: Test examples | ||
runs-on: ubuntu-latest | ||
needs: [rustfmt, clippy-schema] | ||
#needs: [rustfmt, clippy-schema] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
I think I need a better description of what is in this PR. It seems some stuff was removed. What is the reference for that? The linked issue does not seem to match with the changes. In addition, the PR includes an update of the Rust version. Is that related or unrelated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
See the related issue (BASE-558)
Checklist
hard-to-understand areas.