Disable checkpointing properly if openPMD is missing #5493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikbuibui
commented
Sep 30, 2025
| } | ||
|
|
||
| // Checkpoints are expected to be sorted chronologically. | ||
| bool const stepFound = std::binary_search(checkpoints.cbegin(), checkpoints.cend(), restartStep); |
Contributor
Author
There was a problem hiding this comment.
I have this logic here
ikbuibui
force-pushed
the
disable_checkpointing
branch
from
5b85557 to
24a14ee
Compare
Moves checkpointing simulation control in its own class Checkpoint class now has a compile time toggle to disable checkpoint/restart functionality Simplified restart state management and changed from using bools to an enum tracking state
ikbuibui
force-pushed
the
disable_checkpointing
branch
from
24a14ee to
6bbde4f
Compare
ikbuibui
changed the title
chillenzer
requested changes
Nov 14, 2025
Contributor
chillenzer
left a comment
chillenzer
left a comment
There was a problem hiding this comment.
Looks okay to me otherwise. Please do the marked renamings.
Member
|
@ikbuibui what is the status of this PR? |
Contributor
Author
|
I still need to address the requested changes, will happen sometime this week. |
Specialized the Checkpointing class template for disabled, i.e. false type Did some renamings Unified the enum to string mapping
ikbuibui
force-pushed
the
disable_checkpointing
branch
2 times, most recently
from
09afb1a to
d456273
Compare
chillenzer
requested changes
Nov 25, 2025
ikbuibui
force-pushed
the
disable_checkpointing
branch
from
d456273 to
b0cf28b
Compare
ikbuibui
force-pushed
the
disable_checkpointing
branch
from
b0cf28b to
6415776
Compare
chillenzer
approved these changes
Nov 26, 2025
Contributor
chillenzer
left a comment
chillenzer
left a comment
There was a problem hiding this comment.
Thanks for bearing with me for so long. We finally made it!
chillenzer
merged commit 3a84b8f
into
ComputationalRadiationPhysics:dev
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves checkpointing simulation control in its own class
Checkpoint class now has a compile time toggle to disable checkpoint/restart functionality (fixes #5480)
Simplified restart state management and changed from using bools to an enum tracking state