T2220 FIX household members when no sponsored child is found

CompassionCH · Mar 3, 2025 · 7619120 · 7619120
1 parent c112d8d
commit 7619120
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/child_compassion/models/child_compassion.py b/child_compassion/models/child_compassion.py
@@ -723,8 +723,9 @@ def child_departed(self):
 
     def _get_last_pictures(self):
         self.ensure_one()
-
         pictures_obj = self.env["compassion.child.pictures"]
+        if not self.image_url:
+            return pictures_obj
         existing = self.pictures_ids
         pictures = pictures_obj.create(
             {"child_id": self.id, "image_url": self.image_url}

diff --git a/child_compassion/models/household.py b/child_compassion/models/household.py
@@ -248,7 +248,7 @@ class HouseholdMembers(models.Model):
 
     beneficiary_local_id = fields.Char()
     child_id = fields.Many2one(
-        "compassion.child", "Child", ondelete="cascade", readonly=False
+        "compassion.child", "Child", ondelete="set null", readonly=False
     )
     household_id = fields.Many2one(
         "compassion.household",