Skip to content

Add more support for typing, fix some typing-related edge case bugs #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

RalfG
Copy link
Member

@RalfG RalfG commented Jun 11, 2025

  • Adds full support for typing with MyPy
  • Removed support for Python 3.9
  • CI: Replaced file hash-based tests for idxml with proper unit tests.
  • CI: Add format checks.

Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 79.95246% with 253 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.23%. Comparing base (95e8218) to head (7487324).

Files with missing lines Patch % Lines
psm_utils/io/mzid.py 39.02% 50 Missing ⚠️
psm_utils/io/ionbot.py 14.28% 30 Missing ⚠️
psm_utils/io/idxml.py 82.09% 29 Missing ⚠️
psm_utils/io/percolator.py 44.68% 26 Missing ⚠️
psm_utils/io/peptide_record.py 66.66% 22 Missing ⚠️
psm_utils/psm_list.py 46.87% 17 Missing ⚠️
psm_utils/io/tsv.py 48.27% 15 Missing ⚠️
psm_utils/peptidoform.py 75.80% 15 Missing ⚠️
psm_utils/io/__init__.py 62.50% 9 Missing ⚠️
psm_utils/io/pepxml.py 55.00% 9 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   69.12%   70.23%   +1.10%     
==========================================
  Files          30       30              
  Lines        2802     3047     +245     
==========================================
+ Hits         1937     2140     +203     
- Misses        865      907      +42     
Flag Coverage Δ
unittests 70.23% <79.95%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RalfG RalfG marked this pull request as ready for review August 8, 2025 13:55
@RalfG RalfG requested a review from paretje August 8, 2025 13:56
@RalfG RalfG added enhancement Improvement of an existing feature Infrastructure Project structure and CI/CD labels Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature Infrastructure Project structure and CI/CD
Development

Successfully merging this pull request may close these issues.

1 participant