Hook up TokenizingTextBox AutoSuggestBoxStyle #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miksalmon
changed the title
|
@dotnet-policy-service agree company="Microsoft" |
components/TokenizingTextBox/src/TokenizingTextBoxItem.AutoSuggestBox.xaml
Show resolved
Hide resolved
michael-hawker
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Definitely some future investigation we can see if we can simplify the reliance on the custom style, but the PR is good as-is.
@niels9001 validated that the custom style was still needed to some degree, so we won't touch it here and use the existing setup.
The merged dictionary means this is properly grabbing the right style, so all is good.
michael-hawker
force-pushed
the
miksalmon/TokenizingTextBox-AutoSuggestBoxStyle
branch
from
e42cff4 to
c97c0f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #656
The AutoSuggestBoxStyle dependency property is not hooked up to the AutoSuggestBox's style in TokenizingTextBoxItemTextStyle. Is uses the static resource SystemAutoSuggestBoxStyle.
This fix sets the AutoSuggestBox's style in TokenizingTextBoxItemTextStyle to the AutoSuggestBoxStyle of the TokenizingTextBox and sets the AutoSuggestBoxStyle's default value to that of SystemAutoSuggestBoxStyle.
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
TokenizingTextBox's AutoSuggestBoxStyle is not applied
What is the new behavior?
TokenizingTextBox's AutoSuggestBoxStyle is applied
PR Checklist