-
Notifications
You must be signed in to change notification settings - Fork 73
added support foer base64 (dataurl) and file:/// sources url for markdown #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…down image parser
@dotnet-policy-service agree |
@Fefedu973 the command you issued was incorrect. Please try again. Examples are:
and
|
@dotnet-policy-service agree |
Thanks @Fefedu973 for the PR, though I don't think we had an issue on this, that's the best place to start. These can already be handled by the IImageProvider contract to allow the application the most power in deciding what content it supports and loads. We don't want to be arbitrarily loading bits. It could be better for the contract of the config to maybe provide a list of IImageProviders so that it's easier for the app to delegate responsibility for certain things per provider. Then we could provider a few default providers, such as ones that allow loading from disk or from data as you've done here instead. This way the behavior of if an application allows these data forms is configurable and they can customize any extra behavior (such as loading from a virtual file system). |
No description provided.