Fix --fill-verbose parameter conflict in scheduled releases workflow #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uled releases The --body parameter was overriding the --fill-verbose flag, preventing the PR description from being populated with commit details. Removed --body to allow --fill-verbose to work correctly.
- Add commit check step following build.yml pattern - Skip PR creation when no new commits between rel/weekly and main - Satisfy linter by declaring HAS_NEW_COMMITS environment variable - Prevents workflow failure when branches are synchronized
michael-hawker
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
--fill-verboseflag in the scheduled releases workflow wasn't working as expected. Instead of populating the PR description with detailed commit information from changes betweenrel/weeklyandmain, it was only showing the generic message we provided via the--bodyparameter.Root Cause
After investigating the GitHub CLI documentation (
gh pr create --help), we discovered that when both--bodyand--fill-verboseflags are provided together, the--bodyparameter takes precedence and overwrites any autofilled content from--fill-verbose.Solution
Removed the conflicting
--bodyparameter from thegh pr createcommand in the scheduled releases workflow.Additional Issue Discovered
When testing the fix with
gh pr create --fill-verbose --dry-run, we discovered that the command fails with "could not find any commits between origin/rel/weekly and main" when the branches are synchronized (no new commits). This would cause the scheduled workflow to fail when there's nothing to release.Additional Solution
Added early exit logic following the same pattern used in
build.yml- the workflow now checks if there are new commits betweenrel/weeklyandmainbefore attempting to create a PR, preventing failures when branches are synchronized.End Result