-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update title bar note to mention that it's in 1.7 version (and in preview on the current date) #640
Conversation
@dotnet-policy-service agree |
@xakpc It seems you may have confused the The While it might be good to merge these changes anyway just to keep things updated, it seems the link you've added doesn't include any information about the plans for TitleBar in the Windows App SDK. We need to fix that before we proceed here. |
Thanks, I understand that now. It just took me some time to figure it out because of the message, hence the PR.
I see it moved from experimental to preview, which is nice. |
This will ship as part of 1.7, so we can probably just call that out directly vs. mentioning the prior 1.6 stuff. We should probably scope this to be more of "If you're using the Windows App SDK with WinUI, you can leverage the TitleBar control that shipped in the 1.7 release over this one."? |
Updated, but I kept mention that it's in preview on this date to avoid confusion |
This PR contains a small fix to a note regarding TitleBar availability.
I spent 30 minutes trying to figure TitleBar out, only to discover that it was postponed from stable version 1.6.
To prevent others from wasting time on such a trivial thing, I updated the note a bit.