Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update title bar note to mention that it's in 1.7 version (and in preview on the current date) #640

Merged
merged 5 commits into from
Mar 18, 2025

Conversation

xakpc
Copy link
Contributor

@xakpc xakpc commented Feb 8, 2025

This PR contains a small fix to a note regarding TitleBar availability.

I spent 30 minutes trying to figure TitleBar out, only to discover that it was postponed from stable version 1.6.
To prevent others from wasting time on such a trivial thing, I updated the note a bit.

@xakpc
Copy link
Contributor Author

xakpc commented Feb 8, 2025

@dotnet-policy-service agree

@Arlodotexe
Copy link
Member

@xakpc It seems you may have confused the TitleBar we've created in the CommunityToolkit for the TitleBar created by the platform team to include in the Windows App SDK.

The TitleBar available in WCT Labs is available to use from the Labs nuget feed for both UWP and Windows App SDK. You can use this today while you wait for the platform to finish sorting their version.

While it might be good to merge these changes anyway just to keep things updated, it seems the link you've added doesn't include any information about the plans for TitleBar in the Windows App SDK.

We need to fix that before we proceed here.

@xakpc
Copy link
Contributor Author

xakpc commented Feb 20, 2025

@xakpc It seems you may have confused the TitleBar we've created in the CommunityToolkit for the TitleBar created by the platform team to include in the Windows App SDK.

The TitleBar available in WCT Labs is available to use from the Labs nuget feed for both UWP and Windows App SDK. You can use this today while you wait for the platform to finish sorting their version.

Thanks, I understand that now. It just took me some time to figure it out because of the message, hence the PR.

While it might be good to merge these changes anyway just to keep things updated, it seems the link you've added doesn't include any information about the plans for TitleBar in the Windows App SDK.

We need to fix that before we proceed here.

I see it moved from experimental to preview, which is nice.
I put the link that points to Version 1.7 Preview 1 (1.7-preview1) page, to the 'New Title Bar' section.

@michael-hawker
Copy link
Member

This will ship as part of 1.7, so we can probably just call that out directly vs. mentioning the prior 1.6 stuff.

We should probably scope this to be more of "If you're using the Windows App SDK with WinUI, you can leverage the TitleBar control that shipped in the 1.7 release over this one."?

@xakpc xakpc changed the title fix: update title bar note to mention that it's postponed fix: update title bar note to mention that it's in 1.7 version (and in preview on the current date) Feb 25, 2025
@xakpc
Copy link
Contributor Author

xakpc commented Feb 25, 2025

This will ship as part of 1.7, so we can probably just call that out directly vs. mentioning the prior 1.6 stuff.

We should probably scope this to be more of "If you're using the Windows App SDK with WinUI, you can leverage the TitleBar control that shipped in the 1.7 release over this one."?

Updated, but I kept mention that it's in preview on this date to avoid confusion

@Arlodotexe Arlodotexe enabled auto-merge March 18, 2025 13:18
@Arlodotexe Arlodotexe merged commit d6c06d1 into CommunityToolkit:main Mar 18, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants