Skip to content

Ensure SQLite Web always pulls latest image #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oondriss wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −4
Open

Ensure SQLite Web always pulls latest image #1467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CommunityToolkit.Aspire.Hosting.Sqlite/SqliteResourceBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ public static IResourceBuilder<SqliteResource> WithSqliteWeb(this IResourceBuild
var resourceBuilder = builder.ApplicationBuilder.AddResource(resource)
.WithImage(SqliteContainerImageTags.SqliteWebImage, SqliteContainerImageTags.SqliteWebTag)
.WithImageRegistry(SqliteContainerImageTags.SqliteWebRegistry)
.WithImagePullPolicy(ImagePullPolicy.Always)
.WithHttpEndpoint(targetPort: 8080, name: "http")
.WithArgs(builder.Resource.DatabaseFileName)
.WithBindMount(builder.Resource.DatabasePath, "/data")
Expand Down
10 changes: 7 additions & 3 deletions tests/CommunityToolkit.Aspire.Hosting.Sqlite.Tests/AddSqliteTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,13 @@ public async Task SqliteWebResourceConfigured()
Assert.Equal(SqliteContainerImageTags.SqliteWebTag, imageAnnotation.Tag);
Assert.Equal(SqliteContainerImageTags.SqliteWebRegistry, imageAnnotation.Registry);

var env = await sqliteWeb.GetArgumentListAsync();
var envVar = Assert.Single(env);
Assert.Equal(sqlite.Resource.DatabaseFileName, envVar);
Assert.True(sqliteWeb.TryGetAnnotationsOfType<ContainerImagePullPolicyAnnotation>(out var imagePullPolicyAnnotations));
var imagePullPolicyAnnotation = Assert.Single(imagePullPolicyAnnotations);
Assert.Equal(ImagePullPolicy.Always, imagePullPolicyAnnotation.ImagePullPolicy);

var args = await sqliteWeb.GetArgumentListAsync();
var databaseFileName = Assert.Single(args);
Assert.Equal(sqlite.Resource.DatabaseFileName, databaseFileName);

Assert.True(sqliteWeb.TryGetAnnotationsOfType<ContainerMountAnnotation>(out var bindMountAnnotations));
var bindMountAnnotation = Assert.Single(bindMountAnnotations);
Expand Down
15 changes: 14 additions & 1 deletion tests/CommunityToolkit.Aspire.Hosting.Sqlite.Tests/AppHostTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,19 @@ public async Task ResourceStartsAndDbFileExists()
Assert.True(File.Exists(dataSource.ToString()));
}

[Fact]
public async Task SqliteWebResourceStarts()
{
var resourceName = "sqlite-sqliteweb";
await fixture.ResourceNotificationService.WaitForResourceHealthyAsync(resourceName).WaitAsync(TimeSpan.FromMinutes(5));
var httpClient = fixture.CreateHttpClient(resourceName, endpointName: "http");

var response = await httpClient.GetAsync("/");

Assert.Equal(HttpStatusCode.OK, response.StatusCode);
Assert.Contains("SQLite Web", await response.Content.ReadAsStringAsync());
}

[Fact]
public async Task ApiServiceCreateTestItemWithSqliteClient()
{
Expand Down Expand Up @@ -72,4 +85,4 @@ public class Blog
public required string Url { get; set; }

}
}
}
Loading