Skip to content

refactor(signer): Use config-based header to extract IP from #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 21, 2025
Merged

refactor(signer): Use config-based header to extract IP from #388

merged 8 commits into from
Oct 21, 2025

Conversation

@ManuelBilbao
Copy link
Collaborator

@ManuelBilbao ManuelBilbao commented Oct 1, 2025 •
edited
Loading

Add a config param to set the trusted HTTP header to get the user's IP from

@ManuelBilbao ManuelBilbao self-assigned this Oct 1, 2025
@ManuelBilbao ManuelBilbao added the signer Signer module label Oct 1, 2025
@ManuelBilbao ManuelBilbao changed the base branch from main to sigp-audit-fixes October 1, 2025 22:12
@ManuelBilbao ManuelBilbao marked this pull request as ready for review October 2, 2025 13:55
jclapis
jclapis requested changes Oct 13, 2025
View reviewed changes
@ManuelBilbao ManuelBilbao requested a review from jclapis October 21, 2025 14:47
jclapis
jclapis approved these changes Oct 21, 2025
View reviewed changes
Copy link
Collaborator

@jclapis jclapis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few documentation amendment suggestions, but they aren't crucial if they're going to block merging.

@ManuelBilbao ManuelBilbao merged commit e58d67e into sigp-audit-fixes Oct 21, 2025
2 checks passed
@ManuelBilbao ManuelBilbao deleted the trusted_ip_header_config branch October 21, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jclapis jclapis jclapis approved these changes

@ltitanb ltitanb Awaiting requested review from ltitanb

Assignees

@ManuelBilbao ManuelBilbao

Labels

signer Signer module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ManuelBilbao @jclapis