[WIP] - Fix misc findings from reaudit #376
Draft
+260
−144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work In Progress
This fixes several smaller miscellaneous findings from the reaudit assessment.
CBST2-01
CBST2-04
handle_reload()
now updates the state atomically once all of the code has succeeded, and doesn't update it at all if any failures occur.CBST2-06
X-Forwarded-For
header first, then theX-Real-IP
header, then the falls back to the direct connection IP.CBST2-14