[WIP] Fix: Escape closes Settings dialog if login dialog open #3996

[ssidharth010]

Fix for: #3996

Problem:

The ESC button closes the dialog opened below rather than top.

Root Cause:

Since there is not close button configured on the login modal, but on the settings modal it have close button configuration.
Prime vue dialog takes only the one first one hence closing that dialog only.
primefaces/primevue#5138

Solution:

Current temporary solution is simply to add close button to Login modal.

Other solutions:

CloseOnEsc in the DialogStore config will always be kept false and a function can be written in the KeyBindingService to handle close on esc by closing only if the top most dialog has closable set to true

┆Issue is synchronized with this Notion page by Unito

[webfiltered]

Currently, pressing escape closes both the user and settings dialogs.

Would it be possible to have escape close the user dialog, then close settings, to bring this in line with stacked dialogs elsewhere in the app?

[ssidharth010]

Currently from what i have checked with prime vue dialog doesn't have the option to configure that way.
The only options is to update our current flows to update the closeOnEsc to false for all the dialogs below the active dialog. This is the only work around that I can find at the moment.
This will also be a major change.

[christian-byrne]

The only options is to update our current flows to update the closeOnEsc to false for all the dialogs below the active dialog. This is the only work around that I can find at the moment.

In the dialogStore or dialogService, we can expose a function to close the "highest" dialog, while respecting the ranking system, then add the esc keyhandler to all dialogs that have close on escape prop enabled currently, then remove the close on escape prop. What do you think?

[ssidharth010]

The only options is to update our current flows to update the closeOnEsc to false for all the dialogs below the active dialog. This is the only work around that I can find at the moment.

In the dialogStore or dialogService, we can expose a function to close the "highest" dialog, while respecting the ranking system, then add the esc keyhandler to all dialogs that have close on escape prop enabled currently, then remove the close on escape prop. What do you think?

Sure, i think that's the way to go.
I'll make the necessary changes.

[ssidharth010]

@webfiltered I'll close this MR. Please continue the review on the below MR, I had some rebase issues with current branch.
#4364