-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sound notification #3270
base: main
Are you sure you want to change the base?
Add sound notification #3270
Conversation
2d6a3c4
to
84dc6d6
Compare
84dc6d6
to
0419081
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you attach steps with screenshots how this feature should be used?
How do I enable/disable the sound notification? User probably don't want to re-upload an audio file to re-enable it. We should also provide a default sound effect. |
As for enable/disable, how about adding a mute setting (and perhaps volume setting) to each of the two? I thought this feature could be opt-in, so a default sound would not be needed. |
I think if no custom sound is provided, we can use the classic linux |
OK. As we can't play the system beep sound from frontend, I'll try to find some license-free sound file online that we can add to the repository. |
This PR adds a feature to play sound file on prompt completion.
2 new setting entries are added to configure audio files that are played on the following events:
I'm aware there are some custom nodes for sound notification, but