Skip to content

[Feature] Enhance selection toolbox to support bypassing group nodes #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/components/graph/SelectionToolbox.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,22 @@
>
<ColorPickerButton v-show="nodeSelected || groupSelected" />
<Button
v-show="nodeSelected"
v-show="nodeSelected || groupSelected"
severity="secondary"
text
@click="
() => commandStore.execute('Comfy.Canvas.ToggleSelectedNodes.Bypass')
() =>
nodeSelected
? commandStore.execute('Comfy.Canvas.ToggleSelectedNodes.Bypass')
: commandStore.execute(
'Comfy.Canvas.ToggleSelectedNodes.BypassGroup'
)
"
data-testid="bypass-button"
v-tooltip.top="{
value: t('commands.Comfy_Canvas_ToggleSelectedNodes_Bypass.label'),
value: nodeSelected
? t('commands.Comfy_Canvas_ToggleSelectedNodes_Bypass.label')
: t('commands.Comfy_Canvas_ToggleSelectedNodes_BypassGroup.label'),
showDelay: 1000
}"
>
Expand Down
36 changes: 36 additions & 0 deletions src/composables/useCoreCommands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,32 @@ export function useCoreCommands(): ComfyCommand[] {
})
}

const getNodesInSelectedGroups = (): LGraphNode[] => {
const selectedGroups = Array.from(app.canvas.selectedItems).filter(
(item) => item instanceof LGraphGroup
) as LGraphGroup[]
const nodes: LGraphNode[] = []
for (const group of selectedGroups) {
group.recomputeInsideNodes()
for (const node of group.nodes) {
if (!nodes.includes(node)) {
nodes.push(node)
}
}
}
return nodes
}

const toggleSelectedGroupsMode = (mode: LGraphEventMode) => {
getNodesInSelectedGroups().forEach((node) => {
if (node.mode === mode) {
node.mode = LGraphEventMode.ALWAYS
} else {
node.mode = mode
}
})
}

return [
{
id: 'Comfy.NewBlankWorkflow',
Expand Down Expand Up @@ -379,6 +405,16 @@ export function useCoreCommands(): ComfyCommand[] {
app.canvas.setDirty(true, true)
}
},
{
id: 'Comfy.Canvas.ToggleSelectedNodes.BypassGroup',
icon: 'pi pi-shield',
label: 'Bypass Group Nodes',
versionAdded: '1.13.5',
function: () => {
toggleSelectedGroupsMode(LGraphEventMode.BYPASS)
app.canvas.setDirty(true, true)
}
},
{
id: 'Comfy.Canvas.ToggleSelectedNodes.Pin',
icon: 'pi pi-pin',
Expand Down
3 changes: 3 additions & 0 deletions src/locales/en/commands.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@
"Comfy_Canvas_ToggleSelectedNodes_Bypass": {
"label": "Bypass/Unbypass Selected Nodes"
},
"Comfy_Canvas_ToggleSelectedNodes_BypassGroup": {
"label": "Bypass/Unbypass Group Nodes"
},
"Comfy_Canvas_ToggleSelectedNodes_Collapse": {
"label": "Collapse/Expand Selected Nodes"
},
Expand Down