Add integer math nodes (Add, Subtract, Multiply, Divide) - Fixes #11995#11999
Add integer math nodes (Add, Subtract, Multiply, Divide) - Fixes #11995#11999jackdevis wants to merge 2 commits intoComfy-Org:masterfrom
Conversation
jackdevis
requested review from
Kosinkadink,
comfyanonymous and
guill
as code owners
|
I think this stuff should be implemented more generically using MatchType. Many of these work just as well with float inputs, or even strings, tensors and images (I think + would even work on conditionings, as ConditioningCombine, since it's just a list). Technically the inputs don't even need to be the same type, so at least the second parameter could be an Any type. I'd maybe take the output type from the type of the first input and just let the rest be anytypes. You can also make the input list autogrow for more than two operands. It's up to the user to know if the operations make sense for the input types. |
|
Totally agree with your opinion @asagi4 . |
|
PR is updated, please review my PR. Regards |
|
I have no objections to this version. Maybe there's a nice way to make the input types even more flexible, but this would already be an improvement, and the types can always be relaxed later without breaking backwards compatibility. |
Test Evidence CheckIf this PR modifies behavior that requires testing, a test explanation is required. PRs lacking applicable test explanations may not be reviewed until added. Please add test explanations to ensure code quality and prevent regressions. If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided. You can add it by:
|
3 participants
No description provided.