Skip to content

Fix typo in ops.py#11925

Open
NAM-MAN wants to merge 1 commit intoComfy-Org:masterfrom
NAM-MAN:fix-typo-ops
Open

Fix typo in ops.py#11925
NAM-MAN wants to merge 1 commit intoComfy-Org:masterfrom
NAM-MAN:fix-typo-ops

Conversation

@NAM-MAN
Copy link

@NAM-MAN NAM-MAN commented Jan 17, 2026

No description provided.

rattus128
rattus128 previously approved these changes Jan 18, 2026
@Kosinkadink
Copy link
Member

The typo is not fixed completely - it should either remove the 'a' completely to be grammatically correct or say 'a legacy argument'.

I saw that you make a lot of PRs to fix typos in random big repos haha, with 170 commits made on January 17th. I'm curious about your process of making these PRs. Do you already have the big repos sorted in a .txt somewhere, and then autogen the small PRs?

@NAM-MAN
Copy link
Author

NAM-MAN commented Jan 20, 2026

Thanks for catching that! You're right - "a legacy argument" is grammatically correct. I've updated the PR.

Regarding your question about the process - no automation here, just a weekend project! 😄

I manually grep for common typo patterns (like "a a", "the the", "to to") across repos I'm interested in or use regularly, then review each match by hand to make sure it's actually a typo and not intentional (like in test fixtures or string literals).

The high commit count on Jan 17th was just me being in the zone after finding a good workflow. Each PR is reviewed individually to ensure the fix is correct and doesn't break anything - though as you pointed out, I missed the grammar issue here!

Appreciate the thorough review 🙏

@Kosinkadink Kosinkadink added the For PR Review Will be looked at during next PR review; once checked/responded to, this label will be removed. label Jan 22, 2026
@comfy-pr-bot
Copy link
Member

Test Evidence Check

⚠️ Warning: Test Explanation Missing

If this PR modifies behavior that requires testing, a test explanation is required. PRs lacking applicable test explanations may not be reviewed until added. Please add test explanations to ensure code quality and prevent regressions.

⚠️ Warning: Visual Documentation Missing

If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided.

You can add it by:

  • GitHub: Drag & drop media directly into the PR description
  • YouTube: Include a link to a short demo

@Kosinkadink Kosinkadink removed the For PR Review Will be looked at during next PR review; once checked/responded to, this label will be removed. label Jan 22, 2026
@rattus128
Copy link
Contributor

Thanks for catching that! You're right - "a legacy argument" is grammatically correct. I've updated the PR.

Regarding your question about the process - no automation here, just a weekend project! 😄

I manually grep for common typo patterns (like "a a", "the the", "to to") across repos I'm interested in or use regularly, then review each match by hand to make sure it's actually a typo and not intentional (like in test fixtures or string literals).

The high commit count on Jan 17th was just me being in the zone after finding a good workflow. Each PR is reviewed individually to ensure the fix is correct and doesn't break anything - though as you pointed out, I missed the grammar issue here!

Appreciate the thorough review 🙏

When I wrote that I am specifically referring to having the value as

Thanks for catching that! You're right - "a legacy argument" is grammatically correct. I've updated the PR.

Regarding your question about the process - no automation here, just a weekend project! 😄

I manually grep for common typo patterns (like "a a", "the the", "to to") across repos I'm interested in or use regularly, then review each match by hand to make sure it's actually a typo and not intentional (like in test fixtures or string literals).

The high commit count on Jan 17th was just me being in the zone after finding a good workflow. Each PR is reviewed individually to ensure the fix is correct and doesn't break anything - though as you pointed out, I missed the grammar issue here!

Appreciate the thorough review 🙏

"legacy mode" seems more precise than "legacy argument". I used legacy as the noun to make it more general in intent than just the argument specifically.

@NAM-MAN
Copy link
Author

NAM-MAN commented Jan 23, 2026

Thanks @rattus128! Updated to "legacy mode" - that makes sense to keep it more general. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants