Conversation
|
The typo is not fixed completely - it should either remove the 'a' completely to be grammatically correct or say 'a legacy argument'. I saw that you make a lot of PRs to fix typos in random big repos haha, with 170 commits made on January 17th. I'm curious about your process of making these PRs. Do you already have the big repos sorted in a .txt somewhere, and then autogen the small PRs? |
|
Thanks for catching that! You're right - "a legacy argument" is grammatically correct. I've updated the PR. Regarding your question about the process - no automation here, just a weekend project! 😄 I manually grep for common typo patterns (like "a a", "the the", "to to") across repos I'm interested in or use regularly, then review each match by hand to make sure it's actually a typo and not intentional (like in test fixtures or string literals). The high commit count on Jan 17th was just me being in the zone after finding a good workflow. Each PR is reviewed individually to ensure the fix is correct and doesn't break anything - though as you pointed out, I missed the grammar issue here! Appreciate the thorough review 🙏 |
Test Evidence CheckIf this PR modifies behavior that requires testing, a test explanation is required. PRs lacking applicable test explanations may not be reviewed until added. Please add test explanations to ensure code quality and prevent regressions. If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided. You can add it by:
|
When I wrote that I am specifically referring to having the value as
"legacy mode" seems more precise than "legacy argument". I used legacy as the noun to make it more general in intent than just the argument specifically. |
|
Thanks @rattus128! Updated to "legacy mode" - that makes sense to keep it more general. 👍 |
No description provided.