Repository navigation
Conversation
Tests now import `react-data-grid` instead of relative `src` paths. `vp test` aliases it to `src/index.ts`, while `vp run ci` sets `TEST_LIB=true` to test the packed `lib/` and its `styles.css`. The root `ecij()` plugin now uses the same class prefix as `vp pack`, so classnames that tests still import from `src/` match `lib/`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4209 +/- ##
==========================================
- Coverage 98.41% 3.24% -95.17%
==========================================
Files 45 45
Lines 1951 1851 -100
Branches 727 637 -90
==========================================
- Hits 1920 60 -1860
- Misses 31 1791 +1760 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Cool idea, but it doesn't work well with code coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests now import
react-data-gridinstead of relativesrcpaths, sovp run cican run them against the packedlib/, which is what we publish.vp test/vp run testaliasreact-data-gridtosrc/index.tswithtest.alias, so day-to-day testing doesn't needvp pack.vp run ciruns its tests withTEST_LIB=true, which drops the alias and loadslib/styles.cssas a setup file.TEST_LIBis in thetesttask's cache env, sosrc/andlib/results are cached separately.TEST_LIBis separate fromCI, sovp run test test/visual --updatein the screenshot workflow, which doesn't pack, keeps testingsrc/. Visual tests are still enabled byCIalone.tsconfig.test.jsonmapsreact-data-gridtosrc/index.ts, sincevp run typecheckruns beforevp pack.A few tests still import internal classnames that aren't public (
src/style/cell,src/style/row,src/HeaderRow). They compiled with the rootecij()plugin's defaultcss-prefix, whilelib/usesrdg-<version>-, so 63 tests failed againstlib/. The root plugin now sharesclassPrefixwithvp pack; as a side effect, the website also getsrdg-<version>-classes.AGENTS.mdnotes thatvp run citestslib/whilevp testtestssrc/.Verified locally:
vp run ci(544 passed, 3 skipped againstlib/) andvp test(544 passed, 3 skipped againstsrc/). Visual tests only run in CI.🤖 Generated with Claude Code