Skip to content

FEAT: implement general dispersion integral #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
redeboer merged 70 commits into from
Jan 30, 2026
Merged

FEAT: implement general dispersion integral #480

redeboer merged 70 commits into from
Jan 30, 2026

Conversation

@Zeyna777
Copy link
Contributor

@Zeyna777 Zeyna777 commented Sep 25, 2025 •
edited by redeboer
Loading

Zeyna777 and others added 21 commits September 22, 2025 12:03
@Zeyna777
add breakup momentum with separate sqrts
c986e54
@Zeyna777
adjust phsp factor definition
8bfe59c
@Zeyna777
adjust phspfactor abs
50a7b4f
@Zeyna777
readjust phsp factor abs and ajust phps facrot complex sqrt
52c6784
@Zeyna777
adjust Chew Mandelstam S wave
8533574
@Zeyna777
create notebook for plotting new break up moimentum and redefined phs…
d7fe516 
…p factor
@pre-commit-ci
MAINT: implement pre-commit autofixes
5bc8f21
@Zeyna777
change latex print of br momentum
cc3e03d
@Zeyna777
add plot
ec81651
@pre-commit-ci
MAINT: implement pre-commit autofixes
46956e8
@Zeyna777
add sympify false to br momentum
83d9474
@Zeyna777
add complex break up momentum
8b4f596
@Zeyna777
add plots for old implementation of q and rho
4612f40
@Zeyna777
adjust cut structure
f631630
@Zeyna777
fix spelling
fe7fe6d
@Zeyna777
put definition of symbolic dispersion integral
275c3f6
@Zeyna777
change phsp factor definition
9583afe
@Zeyna777
change phsp factor definition
f476a9e
@Zeyna777
add more discription and delete old nb
662754b
@Zeyna777
make epsilon ... default variable which are overwritten when given re…
9a2cbda 
…st args
@Zeyna777
implemet coupling definition of flatte and make sliders work
e0eaa67
@review-notebook-app
Copy link

review-notebook-app bot commented Sep 25, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@Zeyna777 Zeyna777 requested review from Copilot and redeboer and removed request for Copilot September 25, 2025 14:09
@Zeyna777 Zeyna777 self-assigned this Sep 25, 2025
@Zeyna777 Zeyna777 added the ✨ Feature New feature added to the package label Sep 25, 2025
@redeboer redeboer force-pushed the analytic_phasespace_factor branch 3 times, most recently from 4d72d60 to f6b8b06 Compare January 27, 2026 13:28
@redeboer redeboer force-pushed the analytic_phasespace_factor branch from f6b8b06 to 301623c Compare January 27, 2026 13:33
redeboer
redeboer approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good 🌮
For #480 (comment), it's maybe better to create a separate PR that then closes #259. In that PR, we can then also split up the analytic-continuation.ipynb notebook several notebooks that explain features that are related to analyticity (e.g. continuation below a threshold as well as continuation into other Riemann sheets).

redeboer
redeboer requested changes Jan 27, 2026
View reviewed changes
Copy link
Member

@redeboer redeboer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zeyna777 could you make this notebook a bit more explanatory?
https://ampform--480.org.readthedocs.build/480/usage/dynamics/riemann-sheets.html

For testing what the notebook looks like, start a server

poe doclive

and edit the notebook meanwhile

poe lab

with output cells saved after running the notebook in order to what the notebooks looks like in the website rendering.

redeboer
redeboer requested changes Jan 28, 2026
View reviewed changes
Copy link
Member

@redeboer redeboer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only change the first 1D plot, that you plot using linspace, rather than a slice from the meshgrid

@Zeyna777 Zeyna777 requested a review from redeboer January 29, 2026 16:06
redeboer
redeboer requested changes Jan 30, 2026
View reviewed changes
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would only post an issue about the instability of the numerical integral and link to it.

@redeboer redeboer changed the title FEAT: implement general Chew–Mandelstam function FEAT: implement general dispersion integral Jan 30, 2026
redeboer
redeboer approved these changes Jan 30, 2026
View reviewed changes
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :basecampy:

@redeboer redeboer enabled auto-merge (squash) January 30, 2026 15:29
@redeboer redeboer merged commit 16227f0 into main Jan 30, 2026
25 checks passed
@redeboer redeboer deleted the analytic_phasespace_factor branch January 30, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@redeboer redeboer redeboer approved these changes

Assignees

@Zeyna777 Zeyna777

Labels

✨ Feature New feature added to the package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement general Chew-Mandelstam dispersion integral

2 participants

@Zeyna777 @redeboer