Skip to content

Conversation

@ziasam
Copy link

@ziasam ziasam commented Sep 15, 2020

Ported from OxygenOS and reworked for our alert slider
implementation. We target AudioManager instead of Zen,
icons are also the same as aosp and the dialog uses the
material theme as well as support for our themes.

To use, the alert slider config must be enabled. By default,
the dialog shows on the left side. To move it to the right
side, set the location config to 1.

Change-Id: Ie1954a44cc5242c95a731abd7404379ea638fe70

RakeshBatra and others added 3 commits September 12, 2020 15:30
Ported from OxygenOS and reworked for our alert slider
implementation. We target AudioManager instead of Zen,
icons are also the same as aosp and the dialog uses the
material theme as well as support for our themes.

To use, the alert slider config must be enabled. By default,
the dialog shows on the left side. To move it to the right
side, set the location config to 1.

Change-Id: Ie1954a44cc5242c95a731abd7404379ea638fe70
@mg712702 mg712702 force-pushed the c10 branch 2 times, most recently from abe9f18 to 7ec0a7b Compare September 16, 2020 01:44
RakeshBatra pushed a commit that referenced this pull request Apr 14, 2023
Add null pointer check to avoid system crash.
Meet the below crash log during some app operations then app exits.

F DEBUG   : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x78
F DEBUG   : Cause: null pointer dereference
F DEBUG   : backtrace:
F DEBUG   :       #00 pc 0000000000323858  /system/lib64/libhwui.so
(android::uirenderer::DeferredLayerUpdater::apply()+40)
F DEBUG   :       #1 pc 0000000000323040  /system/lib64/libhwui.so
(_ZNSt3__110__function6__funcIZN7android10uirenderer12renderthread13
DrawFrameTask11postAndWaitEvE3$_0NS_9allocatorIS6_EEFvvEEclEv$c1671e
787f244890c877724752face20+416)

Bug: b/243310920
Signed-off-by: Jessie Hao <[email protected]>
Change-Id: I77226be2bd235852675bb4f7a29589e360269b33
Signed-off-by: Pranav Vashi <[email protected]>
Signed-off-by: SuperDroidBond <[email protected]>
Signed-off-by: RakeshBatra <[email protected]>
Ghosuto pushed a commit that referenced this pull request May 11, 2023
02-13 18:30:27.831 22315 22315 F DEBUG   : Cause: null pointer dereference
02-13 18:30:27.831 22315 22315 F DEBUG   :     x0  b400007ada6a6600  x1  0000007aea3d4a10  x2  b400007ada57a998  x3  0000000000000001
02-13 18:30:27.831 22315 22315 F DEBUG   :     x4  0000007aea3d3f80  x5  b400007abe1f22e0  x6  0000000000000001  x7  0000000000000010
02-13 18:30:27.831 22315 22315 F DEBUG   :     x8  0000000000000000  x9  d3dfa7cb4870f3e0  x10 b400007ada6a6200  x11 0000000000000019
02-13 18:30:27.831 22315 22315 F DEBUG   :     x12 0000000000000050  x13 0000000000000033  x14 b400007ab9559000  x15 b400007ab9559000
02-13 18:30:27.831 22315 22315 F DEBUG   :     x16 0000007c048d96a0  x17 0000007c26d1a2f0  x18 0000007aea2ca000  x19 b400007ada6a6600
02-13 18:30:27.831 22315 22315 F DEBUG   :     x20 b400007ada6a6628  x21 b400007ada6a6600  x22 b400007ad4802e90  x23 b400007ad4802e80
02-13 18:30:27.831 22315 22315 F DEBUG   :     x24 7ffffffffffffff8  x25 1fffffffffffffff  x26 00000000ffffffff  x27 b400007b61ab02a8
02-13 18:30:27.831 22315 22315 F DEBUG   :     x28 b400007b61ab02a8  x29 0000007aea3d47d0
02-13 18:30:27.831 22315 22315 F DEBUG   :     lr  0000007c173f6eb0  sp  0000007aea3d47d0  pc  0000007c173f8b40  pst 0000000020001000
02-13 18:30:27.831 22315 22315 F DEBUG   : backtrace:
02-13 18:30:27.831 22315 22315 F DEBUG   :       #00 pc 0000000000249b40  /system/lib64/libhwui.so (android::uirenderer::AnimatorManager::pushStaging()+112) (BuildId: 31073a6e7866492366c7945e840d3e74)
02-13 18:30:27.831 22315 22315 F DEBUG   :       #1 pc 0000000000247eac  /system/lib64/libhwui.so (android::uirenderer::AnimationContext::runRemainingAnimations(android::uirenderer::TreeInfo&)+44) (BuildId: 31073a6e7866492366c7945e840d3e74)

Signed-off-by: minaripenguin <[email protected]>
Ghosuto pushed a commit that referenced this pull request May 11, 2023
02-13 18:30:27.831 22315 22315 F DEBUG   : Cause: null pointer dereference
02-13 18:30:27.831 22315 22315 F DEBUG   :     x0  b400007ada6a6600  x1  0000007aea3d4a10  x2  b400007ada57a998  x3  0000000000000001
02-13 18:30:27.831 22315 22315 F DEBUG   :     x4  0000007aea3d3f80  x5  b400007abe1f22e0  x6  0000000000000001  x7  0000000000000010
02-13 18:30:27.831 22315 22315 F DEBUG   :     x8  0000000000000000  x9  d3dfa7cb4870f3e0  x10 b400007ada6a6200  x11 0000000000000019
02-13 18:30:27.831 22315 22315 F DEBUG   :     x12 0000000000000050  x13 0000000000000033  x14 b400007ab9559000  x15 b400007ab9559000
02-13 18:30:27.831 22315 22315 F DEBUG   :     x16 0000007c048d96a0  x17 0000007c26d1a2f0  x18 0000007aea2ca000  x19 b400007ada6a6600
02-13 18:30:27.831 22315 22315 F DEBUG   :     x20 b400007ada6a6628  x21 b400007ada6a6600  x22 b400007ad4802e90  x23 b400007ad4802e80
02-13 18:30:27.831 22315 22315 F DEBUG   :     x24 7ffffffffffffff8  x25 1fffffffffffffff  x26 00000000ffffffff  x27 b400007b61ab02a8
02-13 18:30:27.831 22315 22315 F DEBUG   :     x28 b400007b61ab02a8  x29 0000007aea3d47d0
02-13 18:30:27.831 22315 22315 F DEBUG   :     lr  0000007c173f6eb0  sp  0000007aea3d47d0  pc  0000007c173f8b40  pst 0000000020001000
02-13 18:30:27.831 22315 22315 F DEBUG   : backtrace:
02-13 18:30:27.831 22315 22315 F DEBUG   :       #00 pc 0000000000249b40  /system/lib64/libhwui.so (android::uirenderer::AnimatorManager::pushStaging()+112) (BuildId: 31073a6e7866492366c7945e840d3e74)
02-13 18:30:27.831 22315 22315 F DEBUG   :       #1 pc 0000000000247eac  /system/lib64/libhwui.so (android::uirenderer::AnimationContext::runRemainingAnimations(android::uirenderer::TreeInfo&)+44) (BuildId: 31073a6e7866492366c7945e840d3e74)

Signed-off-by: minaripenguin <[email protected]>
Mudit200408 pushed a commit to Mudit200408/colt_frameworks_base that referenced this pull request Jun 2, 2023
* this fixup is based from reported backtrace from crdroid (i have no copy of updated backtrace)

pid: 2564, tid: 2618, name: RenderThread  >>> com.android.systemui <<<
uid: 10293
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0000000000000000
Cause: null pointer dereference
    x0  b40000736242a1e0  x1  0000000000000000  x2  00000073845059b0  x3  0000000000000001
    x4  0000007384504fd0  x5  b4000074120a0244  x6  00000000134813e0  x7  0000000000000010
    x8  0000000000000000  x9  0000000000000000  x10 0000000000000000  x11 b400007443b7cfcc
    x12 000000000000015e  x13 0000000000000000  x14 00000074c626d330  x15 0000000000000000
    x16 00000074d6b35060  x17 00000074e3eea600  x18 00000073841be000  x19 b40000736242a1e0
    x20 b40000741219e640  x21 b4000074131080d0  x22 0000007384506000  x23 00000000ffffffff
    x24 b400007443cf0008  x25 7ffffffffffffff8  x26 1fffffffffffffff  x27 00000000ffffffff
    x28 b4000074061b0da8  x29 0000007384505790
    lr  00000074c6469778  sp  0000007384505790  pc  00000074c6467da8  pst 0000000000001000

backtrace:
      #00 pc 0000000000251da8  /system/lib64/libhwui.so (android::uirenderer::BaseRenderNodeAnimator::pushStaging(android::uirenderer::AnimationContext&)+232) (BuildId: 79dc23449e3f71e7647d99fc4984c53f)
      Colt-Enigma#1 pc 0000000000253774  /system/lib64/libhwui.so (android::uirenderer::AnimatorManager::pushStaging()+596) (BuildId: 79dc23449e3f71e7647d99fc4984c53f)
      Colt-Enigma#2 pc 000000000025132c  /system/lib64/libhwui.so (android::uirenderer::AnimationContext::runRemainingAnimations(android::uirenderer::TreeInfo&)+44) (BuildId: 79dc23449e3f71e7647d99fc4984c53f)
      Colt-Enigma#3 pc 00000000002676c4  /system/lib64/libhwui.so (android::uirenderer::AnimationContextBridge::runRemainingAnimations(android::uirenderer::TreeInfo&)+36) (BuildId: 79dc23449e3f71e7647d99fc4984c53f)
      Colt-Enigma#4 pc 0000000000292780  /system/lib64/libhwui.so (android::uirenderer::renderthread::CanvasContext::prepareTree(android::uirenderer::TreeInfo&, long*, long, android::uirenderer::RenderNode*)+352) (BuildId: 79dc23449e3f71e7647d99fc4984c53f)
      Colt-Enigma#5 pc 0000000000293f00  /system/lib64/libhwui.so (android::uirenderer::renderthread::CanvasContext::prepareAndDraw(android::uirenderer::RenderNode*)+176) (BuildId: 79dc23449e3f71e7647d99fc4984c53f)
      Colt-Enigma#6 pc 00000000002a94dc  /system/lib64/libhwui.so (std::__1::__function::__func<android::uirenderer::renderthread::RenderThread::frameCallback(long, long, long, long)::$_0, std::__1::allocator<android::uirenderer::renderthread::RenderThread::frameCallback(long, long, long, long)::$_0>, void ()>::operator()() (.cf82759fcc28f80417602914fe3f7adc)+172) (BuildId: 79dc23449e3f71e7647d99fc4984c53f)
      #07 pc 0000000000282d44  /system/lib64/libhwui.so (android::uirenderer::WorkQueue::process()+1108) (BuildId: 79dc23449e3f71e7647d99fc4984c53f)
      #08 pc 00000000002a80fc  /system/lib64/libhwui.so (android::uirenderer::renderthread::RenderThread::threadLoop()+556) (BuildId: 79dc23449e3f71e7647d99fc4984c53f)
      #09 pc 0000000000013a14  /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+436) (BuildId: 83f16edd6c377c8ae02f3810c8fdb2cc)
      #10 pc 00000000000ce7fc  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+204) (BuildId: 5c2a466eab8a09587d6f96c2c9b8f088)
      #11 pc 0000000000055cd0  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: 5c2a466eab8a09587d6f96c2c9b8f088)

* it seems like 104a9ac2879042e0129767779c086f7b223a6061 caused a breakage in synchronization across multiple invocations of pushStaging() without fixing the issue.
* this CL attempts to address the synchronization breakage (for race condition) while giving another try to resolve the null point dereference issue (just trying until someone better fixes it for real or until the qs crash bug count reduces to few numbers)
* this CL adds previously remove null checks from f263477f1908bbefdd81e3f1f0dbd16d1a123571 (just changed the null checks to nullptr, credits and thanks for the backtrace), while adding another set of null checks and logs checkpoint for debugging and finally tracing the root cause of this issue.

incase a pro decides to fix this issue for real:

here are captured logs while debugging with null handling checkpoints and stuffs i got

logs:
05-19 16:23:27.475  1780  1862 E OpenGLRenderer: PushStaging: Null animator or animation handle in mAnimators.push_back()
05-19 16:23:27.475  1780  1862 E OpenGLRenderer: PushStaging: Null animator or animation handle in mAnimators.push_back()

* null dereferencing
  - adding anim->target() != nullptr causes white screen when unlocking with pin

Change-Id: If0b014ebbfee7d4c00712a4d193f0ffbb3389012
Signed-off-by: minaripenguin <[email protected]>
RakeshBatra pushed a commit that referenced this pull request Jun 18, 2023
* i thought this was fixed by dropping HB and freetype modifications but a user reported a sysui crash without logcat nor context so im using my old copy

* addr2line was pointing the NPD [1] to a new instance of SkMemoryStream (if im not mistaken)
minaripenguin@minaripenguin:~/bugreport-oriole-TQ2A.230405.003.E1-2023-04-13-09-02-17/FS/data/tombstones$ addr2line -f -e '/mnt/xxxx/xxxxx/out/target/product/oriole/system/lib/libhwui.so' 000000000024a61c
_ZN14SkMemoryStreamC2E5sk_spI6SkDataE

* to temporarily aid the crash issue, until we find and fix the font that causes the crash, silently swallow the errors since the rom shouldn't booting at all if current font in use has invalid data.

[1]
*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
RisingOS Version: '1.0-20230412-UNOFFICIAL-oriole'
Build fingerprint: 'google/oriole/oriole:13/TQ2A.230305.008.E1/9677224:user/release-keys'
Revision: 'MP1.0'
ABI: 'arm64'
Timestamp: 2023-04-13 00:41:15.026955853+0800
Process uptime: 216s
Cmdline: com.android.systemui
pid: 17576, tid: 17613, name: RenderThread  >>> com.android.systemui <<<
uid: 10403
tagged_addr_ctrl: 0000000000000001 (PR_TAGGED_ADDR_ENABLE)
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0000000000000010
Cause: null pointer dereference
    x0  b4000074cc5b7e60  x1  00000072ca63fa20  x2  00000072ca63fa20  x3  0000000000000001
    x4  00000072ca63efa0  x5  000000747c59e4bc  x6  00005a120000edab  x7  0000906f00008280
    x8  0000000000000000  x9  56bd015d3f6fc8f6  x10 0000000000000000  x11 000000000000001a
    x12 0000000000000000  x13 b4000074ecbba980  x14 0000000000000033  x15 0000000000000019
    x16 00000075f74ae6a8  x17 00000075fdb0fec0  x18 00000072ca470000  x19 b4000074cc5b7e60
    x20 b4000074cc5b7e88  x21 b4000074cc5b7e60  x22 b40000737c76ae48  x23 b40000737c76ae30
    x24 7ffffffffffffff8  x25 1fffffffffffffff  x26 00000000ffffffff  x27 b4000073cc52f898
    x28 00000072ca547000  x29 00000072ca63f7e0
    lr  00000075eec487e0  sp  00000072ca63f7e0  pc  00000075eec4a61c  pst 0000000020001000

backtrace:
      #00 pc 000000000024a61c  /system/lib64/libhwui.so (android::uirenderer::AnimatorManager::pushStaging()+108) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #1 pc 00000000002487dc  /system/lib64/libhwui.so (android::uirenderer::AnimationContext::runRemainingAnimations(android::uirenderer::TreeInfo&)+44) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #2 pc 000000000025b2a4  /system/lib64/libhwui.so (android::uirenderer::AnimationContextBridge::runRemainingAnimations(android::uirenderer::TreeInfo&)+36) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #3 pc 000000000027fdcc  /system/lib64/libhwui.so (android::uirenderer::renderthread::CanvasContext::prepareTree(android::uirenderer::TreeInfo&, long*, long, android::uirenderer::RenderNode*)+348) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #4 pc 0000000000282bdc  /system/lib64/libhwui.so (std::__1::__function::__func<android::uirenderer::renderthread::DrawFrameTask::postAndWait()::$_0, std::__1::allocator<android::uirenderer::renderthread::DrawFrameTask::postAndWait()::$_0>, void ()>::operator()() (.c1671e787f244890c877724752face20)+364) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #5 pc 0000000000272c34  /system/lib64/libhwui.so (android::uirenderer::WorkQueue::process()+580) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #6 pc 0000000000292e9c  /system/lib64/libhwui.so (android::uirenderer::renderthread::RenderThread::threadLoop()+412) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #07 pc 0000000000013220  /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+416) (BuildId: 536947a6fb111c99b28090cdd95ee772)
      #08 pc 00000000000bc1cc  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+204) (BuildId: 7c802f36645db769f96376c94049c9cf)
      #09 pc 0000000000055020  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: 7c802f36645db769f96376c94049c9cf)

Signed-off-by: minaripenguin <[email protected]>
Signed-off-by: RakeshBatra <[email protected]>
RakeshBatra pushed a commit that referenced this pull request Jun 18, 2023
* i thought this was fixed by dropping HB and freetype modifications but a user reported a sysui crash without logcat nor context so im using my old copy

* addr2line was pointing the NPD [1] to a new instance of SkMemoryStream (if im not mistaken)
minaripenguin@minaripenguin:~/bugreport-oriole-TQ2A.230405.003.E1-2023-04-13-09-02-17/FS/data/tombstones$ addr2line -f -e '/mnt/xxxx/xxxxx/out/target/product/oriole/system/lib/libhwui.so' 000000000024a61c
_ZN14SkMemoryStreamC2E5sk_spI6SkDataE

* to temporarily aid the crash issue, until we find and fix the font that causes the crash, silently swallow the errors since the rom shouldn't booting at all if current font in use has invalid data.

[1]
*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
RisingOS Version: '1.0-20230412-UNOFFICIAL-oriole'
Build fingerprint: 'google/oriole/oriole:13/TQ2A.230305.008.E1/9677224:user/release-keys'
Revision: 'MP1.0'
ABI: 'arm64'
Timestamp: 2023-04-13 00:41:15.026955853+0800
Process uptime: 216s
Cmdline: com.android.systemui
pid: 17576, tid: 17613, name: RenderThread  >>> com.android.systemui <<<
uid: 10403
tagged_addr_ctrl: 0000000000000001 (PR_TAGGED_ADDR_ENABLE)
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0000000000000010
Cause: null pointer dereference
    x0  b4000074cc5b7e60  x1  00000072ca63fa20  x2  00000072ca63fa20  x3  0000000000000001
    x4  00000072ca63efa0  x5  000000747c59e4bc  x6  00005a120000edab  x7  0000906f00008280
    x8  0000000000000000  x9  56bd015d3f6fc8f6  x10 0000000000000000  x11 000000000000001a
    x12 0000000000000000  x13 b4000074ecbba980  x14 0000000000000033  x15 0000000000000019
    x16 00000075f74ae6a8  x17 00000075fdb0fec0  x18 00000072ca470000  x19 b4000074cc5b7e60
    x20 b4000074cc5b7e88  x21 b4000074cc5b7e60  x22 b40000737c76ae48  x23 b40000737c76ae30
    x24 7ffffffffffffff8  x25 1fffffffffffffff  x26 00000000ffffffff  x27 b4000073cc52f898
    x28 00000072ca547000  x29 00000072ca63f7e0
    lr  00000075eec487e0  sp  00000072ca63f7e0  pc  00000075eec4a61c  pst 0000000020001000

backtrace:
      #00 pc 000000000024a61c  /system/lib64/libhwui.so (android::uirenderer::AnimatorManager::pushStaging()+108) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #1 pc 00000000002487dc  /system/lib64/libhwui.so (android::uirenderer::AnimationContext::runRemainingAnimations(android::uirenderer::TreeInfo&)+44) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #2 pc 000000000025b2a4  /system/lib64/libhwui.so (android::uirenderer::AnimationContextBridge::runRemainingAnimations(android::uirenderer::TreeInfo&)+36) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #3 pc 000000000027fdcc  /system/lib64/libhwui.so (android::uirenderer::renderthread::CanvasContext::prepareTree(android::uirenderer::TreeInfo&, long*, long, android::uirenderer::RenderNode*)+348) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #4 pc 0000000000282bdc  /system/lib64/libhwui.so (std::__1::__function::__func<android::uirenderer::renderthread::DrawFrameTask::postAndWait()::$_0, std::__1::allocator<android::uirenderer::renderthread::DrawFrameTask::postAndWait()::$_0>, void ()>::operator()() (.c1671e787f244890c877724752face20)+364) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #5 pc 0000000000272c34  /system/lib64/libhwui.so (android::uirenderer::WorkQueue::process()+580) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #6 pc 0000000000292e9c  /system/lib64/libhwui.so (android::uirenderer::renderthread::RenderThread::threadLoop()+412) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #07 pc 0000000000013220  /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+416) (BuildId: 536947a6fb111c99b28090cdd95ee772)
      #08 pc 00000000000bc1cc  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+204) (BuildId: 7c802f36645db769f96376c94049c9cf)
      #09 pc 0000000000055020  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: 7c802f36645db769f96376c94049c9cf)

Signed-off-by: minaripenguin <[email protected]>
Signed-off-by: RakeshBatra <[email protected]>
RakeshBatra pushed a commit that referenced this pull request Jun 18, 2023
* i thought this was fixed by dropping HB and freetype modifications but a user reported a sysui crash without logcat nor context so im using my old copy

* addr2line was pointing the NPD [1] to a new instance of SkMemoryStream (if im not mistaken)
minaripenguin@minaripenguin:~/bugreport-oriole-TQ2A.230405.003.E1-2023-04-13-09-02-17/FS/data/tombstones$ addr2line -f -e '/mnt/xxxx/xxxxx/out/target/product/oriole/system/lib/libhwui.so' 000000000024a61c
_ZN14SkMemoryStreamC2E5sk_spI6SkDataE

* to temporarily aid the crash issue, until we find and fix the font that causes the crash, silently swallow the errors since the rom shouldn't booting at all if current font in use has invalid data.

[1]
*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
RisingOS Version: '1.0-20230412-UNOFFICIAL-oriole'
Build fingerprint: 'google/oriole/oriole:13/TQ2A.230305.008.E1/9677224:user/release-keys'
Revision: 'MP1.0'
ABI: 'arm64'
Timestamp: 2023-04-13 00:41:15.026955853+0800
Process uptime: 216s
Cmdline: com.android.systemui
pid: 17576, tid: 17613, name: RenderThread  >>> com.android.systemui <<<
uid: 10403
tagged_addr_ctrl: 0000000000000001 (PR_TAGGED_ADDR_ENABLE)
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0000000000000010
Cause: null pointer dereference
    x0  b4000074cc5b7e60  x1  00000072ca63fa20  x2  00000072ca63fa20  x3  0000000000000001
    x4  00000072ca63efa0  x5  000000747c59e4bc  x6  00005a120000edab  x7  0000906f00008280
    x8  0000000000000000  x9  56bd015d3f6fc8f6  x10 0000000000000000  x11 000000000000001a
    x12 0000000000000000  x13 b4000074ecbba980  x14 0000000000000033  x15 0000000000000019
    x16 00000075f74ae6a8  x17 00000075fdb0fec0  x18 00000072ca470000  x19 b4000074cc5b7e60
    x20 b4000074cc5b7e88  x21 b4000074cc5b7e60  x22 b40000737c76ae48  x23 b40000737c76ae30
    x24 7ffffffffffffff8  x25 1fffffffffffffff  x26 00000000ffffffff  x27 b4000073cc52f898
    x28 00000072ca547000  x29 00000072ca63f7e0
    lr  00000075eec487e0  sp  00000072ca63f7e0  pc  00000075eec4a61c  pst 0000000020001000

backtrace:
      #00 pc 000000000024a61c  /system/lib64/libhwui.so (android::uirenderer::AnimatorManager::pushStaging()+108) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #1 pc 00000000002487dc  /system/lib64/libhwui.so (android::uirenderer::AnimationContext::runRemainingAnimations(android::uirenderer::TreeInfo&)+44) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #2 pc 000000000025b2a4  /system/lib64/libhwui.so (android::uirenderer::AnimationContextBridge::runRemainingAnimations(android::uirenderer::TreeInfo&)+36) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #3 pc 000000000027fdcc  /system/lib64/libhwui.so (android::uirenderer::renderthread::CanvasContext::prepareTree(android::uirenderer::TreeInfo&, long*, long, android::uirenderer::RenderNode*)+348) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #4 pc 0000000000282bdc  /system/lib64/libhwui.so (std::__1::__function::__func<android::uirenderer::renderthread::DrawFrameTask::postAndWait()::$_0, std::__1::allocator<android::uirenderer::renderthread::DrawFrameTask::postAndWait()::$_0>, void ()>::operator()() (.c1671e787f244890c877724752face20)+364) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #5 pc 0000000000272c34  /system/lib64/libhwui.so (android::uirenderer::WorkQueue::process()+580) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #6 pc 0000000000292e9c  /system/lib64/libhwui.so (android::uirenderer::renderthread::RenderThread::threadLoop()+412) (BuildId: f37109e40765e94e2634e351e2ba0981)
      #07 pc 0000000000013220  /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+416) (BuildId: 536947a6fb111c99b28090cdd95ee772)
      #08 pc 00000000000bc1cc  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+204) (BuildId: 7c802f36645db769f96376c94049c9cf)
      #09 pc 0000000000055020  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: 7c802f36645db769f96376c94049c9cf)

Signed-off-by: minaripenguin <[email protected]>
Signed-off-by: RakeshBatra <[email protected]>
RakeshBatra pushed a commit that referenced this pull request Jul 18, 2023
…n setHidden of TaskDisplayArea

- scenario
1. Device has multiple TDAs and secondary TDA has more than 2 tasks.
2. We can fill the large or extra screen space using multiple TDA's hidden or not.

- problem
1. There are 2 tasks testApp(#1) and launcher(#0) in secondary TDA.
2. Launcher(#0) activity remains FOCUSED, TOP and RESUMED when setHidden of secondary TDA.
3. Task.setForceHidden has designed for not DisplayArea but single task as PIP.
4. After 1st topToBottom loop of forAllTasks, the list changed by #1's moveToBack
and the result #0 skipped setForceHidden.
5. So setForceHidden's moveToBack parameter set true only for the single task.

Change-Id: If536f2751497452a5718cef48604769ce33720d2
Signed-off-by: Yunseon Park <[email protected]>
Signed-off-by: RakeshBatra <[email protected]>
RakeshBatra pushed a commit that referenced this pull request Jul 30, 2023
02-13 18:30:27.831 22315 22315 F DEBUG   : Cause: null pointer dereference
02-13 18:30:27.831 22315 22315 F DEBUG   :     x0  b400007ada6a6600  x1  0000007aea3d4a10  x2  b400007ada57a998  x3  0000000000000001
02-13 18:30:27.831 22315 22315 F DEBUG   :     x4  0000007aea3d3f80  x5  b400007abe1f22e0  x6  0000000000000001  x7  0000000000000010
02-13 18:30:27.831 22315 22315 F DEBUG   :     x8  0000000000000000  x9  d3dfa7cb4870f3e0  x10 b400007ada6a6200  x11 0000000000000019
02-13 18:30:27.831 22315 22315 F DEBUG   :     x12 0000000000000050  x13 0000000000000033  x14 b400007ab9559000  x15 b400007ab9559000
02-13 18:30:27.831 22315 22315 F DEBUG   :     x16 0000007c048d96a0  x17 0000007c26d1a2f0  x18 0000007aea2ca000  x19 b400007ada6a6600
02-13 18:30:27.831 22315 22315 F DEBUG   :     x20 b400007ada6a6628  x21 b400007ada6a6600  x22 b400007ad4802e90  x23 b400007ad4802e80
02-13 18:30:27.831 22315 22315 F DEBUG   :     x24 7ffffffffffffff8  x25 1fffffffffffffff  x26 00000000ffffffff  x27 b400007b61ab02a8
02-13 18:30:27.831 22315 22315 F DEBUG   :     x28 b400007b61ab02a8  x29 0000007aea3d47d0
02-13 18:30:27.831 22315 22315 F DEBUG   :     lr  0000007c173f6eb0  sp  0000007aea3d47d0  pc  0000007c173f8b40  pst 0000000020001000
02-13 18:30:27.831 22315 22315 F DEBUG   : backtrace:
02-13 18:30:27.831 22315 22315 F DEBUG   :       #00 pc 0000000000249b40  /system/lib64/libhwui.so (android::uirenderer::AnimatorManager::pushStaging()+112) (BuildId: 31073a6e7866492366c7945e840d3e74)
02-13 18:30:27.831 22315 22315 F DEBUG   :       #1 pc 0000000000247eac  /system/lib64/libhwui.so (android::uirenderer::AnimationContext::runRemainingAnimations(android::uirenderer::TreeInfo&)+44) (BuildId: 31073a6e7866492366c7945e840d3e74)

Signed-off-by: minaripenguin <[email protected]>
Signed-off-by: Pranav Vashi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants