Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency issues (and other fixes) #564

Merged
merged 10 commits into from
Jan 27, 2025
Merged

Fix dependency issues (and other fixes) #564

merged 10 commits into from
Jan 27, 2025

Conversation

CGNonofr
Copy link
Contributor

fix #563

@CGNonofr CGNonofr requested a review from kaisalmen January 27, 2025 16:33
kaisalmen
kaisalmen approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over all the changes and they look good. The monacoVscodeApiInitialized is simple and effective. LGTM if the pipeline is green. Thank you.

@CGNonofr
Copy link
Contributor Author

The monacoVscodeApiInitialized is simple and effective

Unfortunately it will only work for new versions though!

@CGNonofr CGNonofr merged commit 37b2cb0 into main Jan 27, 2025
2 checks passed
@CGNonofr CGNonofr deleted the dependency-issues branch January 27, 2025 17:04
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 13.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisalmen kaisalmen kaisalmen approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency issues with v13 / questions
2 participants
@CGNonofr @kaisalmen