Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split vscode extension api into new package #561

Merged
merged 12 commits into from
Jan 24, 2025
Merged

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Jan 24, 2025

fix: #559

Breaking changes

  • @codingame/monaco-vscode-api should not be installed as vscode anymore
  • @codingame/monaco-vscode-extension-api can optionally be installed as vscode to use the extension api from the main thread
  • some imports should be updated:
    • vscode/localExtensionHost => vscode/localExtensionHost (unchanged)
    • vscode/* => @codingame/monaco-vscode-api/*
    • vscode/services => @codingame/monaco-vscode-api

@CGNonofr CGNonofr requested a review from kaisalmen January 24, 2025 13:57
@CGNonofr CGNonofr marked this pull request as draft January 24, 2025 14:13
kaisalmen
kaisalmen previously approved these changes Jan 24, 2025
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. LGTM once the build is green. I will test it with monaco-languageclient and report back. Will this become v12.x oder v13

@CGNonofr
Copy link
Contributor Author

Thank you very much. LGTM. I will test it with monaco-languageclient and report back. Will this become v12.x oder v13

Did a mistake, hold on :)

@CGNonofr
Copy link
Contributor Author

Will this become v12.x oder v13

It will be a new major version

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Jan 24, 2025

@kaisalmen ok now it should be fine! (the extension host worker has no reason to be in the extension api package)

@CGNonofr CGNonofr marked this pull request as ready for review January 24, 2025 15:01
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to test this in the field.

@kaisalmen
Copy link
Collaborator

kaisalmen commented Jan 24, 2025

🤞 the build is green

@CGNonofr CGNonofr merged commit cb02f91 into main Jan 24, 2025
2 checks passed
@CGNonofr CGNonofr deleted the split-vscode-extension-api branch January 24, 2025 15:34
Copy link

🎉 This PR is included in version 13.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v12: Many empty common packages are generated
2 participants