-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split vscode extension api into new package #561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. LGTM once the build is green. I will test it with monaco-languageclient
and report back. Will this become v12.x oder v13
Did a mistake, hold on :) |
It will be a new major version |
49da5e3
to
74aa489
Compare
@kaisalmen ok now it should be fine! (the extension host worker has no reason to be in the extension api package) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We need to test this in the field.
🤞 the build is green |
🎉 This PR is included in version 13.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
fix: #559
Breaking changes
@codingame/monaco-vscode-api
should not be installed asvscode
anymore@codingame/monaco-vscode-extension-api
can optionally be installed asvscode
to use the extension api from the main threadvscode/localExtensionHost
=>vscode/localExtensionHost
(unchanged)vscode/*
=>@codingame/monaco-vscode-api/*
vscode/services
=>@codingame/monaco-vscode-api