Revamp build process and update to 1.96.3 #555

CGNonofr · 2025-01-20T20:20:19Z

I'm aware it's a HUGE PR, sorry for that, I don't really expect you to fully understand what has been done about the build process as it would be really time consuming.

It's tried to fix all the issues I've noticed about the build process and decided to fully rework it on healthier bases.

What was improved:

The packages dependencies should now be properly set on all the subpackages
Each vscode module now has its .d.ts next to it, which allows to import any vscode file from the final project with the types
It's faster (there is now only 2 rounds of rollup instead of 3, and no separate types bundling)

Regarding the type, I had to make a choice, because the import graph of types and the one from the actual ESM are different (for instance, if only a type is imported from another module, the import is removed from the generated ESM).

I've decided that only external dependencies imported from actual ESM files are declared in the package dependencies. External dependencies only imported from d.ts files are put in the peerDependencies as optional (using peerDependenciesMeta). Any though about it?

Also, I've upgraded VSCode in the same MR so a new major release is triggered in case something was broken in the process.

And whilte I'm at it, I've updated every single dependencies, including eslint which I've switch to the default recommended configuration for now

const enums are a pain in the ass for libraries

- always keep d.ts near the .js - make code more maintainable - faster - fix subpackage dependencies computation

as it breaks some namespace declarations

CGNonofr · 2025-01-20T22:24:29Z

@kaisalmen do you have an idea about the build error? I've tried many things without any differences 🤔

No issue on my machine of course

kaisalmen · 2025-01-21T08:03:09Z

@CGNonofr awesome. I will look at all the changes later today.

do you have an idea about the build error?

I am locally on Ubunut 24.04.1 and it fails at the same point with a slightly different reason. I will come back to you...

kaisalmen · 2025-01-21T08:12:29Z

@CGNonofr I upgraded volta npm to 22.13.0 (current LTS) and it works locally now so far. It went further but is not yet completed.

kaisalmen · 2025-01-21T08:32:59Z

@CGNonofr now it fails here:

I will install ajv as devDependency and see what happens.

Why is yarn still used?

kaisalmen · 2025-01-21T08:35:38Z

@CGNonofr if yarn is still needed you should also enforce the version with volta

CGNonofr · 2025-01-21T08:56:09Z

I am locally on Ubunut 24.04.1 and it fails at the same point with a slightly different reason. I will come back to you...

Interesting!

I upgraded volta npm to 22.13.0 (current LTS) and it works locally now so far. It went further but is not yet completed.

If you look at the commit history, you would notice that I've tried playing with the node/npm version already (:

if yarn is still needed you should also enforce the version with volta

I was thinking the whole repo has switched from yarn to npm, but maybe not everywhere? 🤔

I've failed to have any issue locally, and I've failed to have any other error then the npm warn cleanup Failed to remove some directories error, no mattern the npm and node version, or if the cache is cleaned..

kaisalmen · 2025-01-21T11:48:22Z

nice! there is another error about ajv though 🤔

That is the same I see locally. Can you patch the vscode package.json to contain those package (ajv and ajv-keywords)?

kaisalmen · 2025-01-21T14:01:18Z

@CGNonofr Getting there...
npm i ✅
npm run build ❌

CGNonofr · 2025-01-21T15:23:10Z

@kaisalmen this time I'm confident :)

kaisalmen · 2025-01-21T15:32:06Z

this time I'm confident :)

🤞

CGNonofr · 2025-01-21T15:43:38Z

this time I'm confident :)

🤞

demo failed !!

kaisalmen · 2025-01-21T16:05:47Z

I'm aware it's a HUGE PR, sorry for that, I don't really expect you to fully understand what has been done about the build process as it would be really time consuming.

Yes, it is much, but I can already see that it is better structured.

I've decided that only external dependencies imported from actual ESM files are declared in the package dependencies. External dependencies only imported from d.ts files are put in the peerDependencies as optional (using peerDependenciesMeta). Any though about it?

This sounds logical. Is this also the reason why you use verbatimModuleSyntax now. I didn't know this existed. I assume this will make the dependency handling in projects using monaco-vscode-api more robust. 👍

You switched to used tsx because ts-node does no longer evolve, right. Is that similar tom vite-node?

Once the build is stable and you can produce a new release, I will test it with monaco-languageclient.

CGNonofr · 2025-01-21T16:35:24Z

Is this also the reason why you use verbatimModuleSyntax now.

We don't really need it, it was part of an experiment that I don't use now. But It looks like a good practice so I've kept it.

You switched to used tsx because ts-node does no longer evolve, right.

I've discovered tsx on another project after fighting with ts-node for hours, and tsx was fully working on the first try! Also ts-node always generates verbose useless warning messages

CGNonofr · 2025-01-21T17:07:56Z

@kaisalmen All green 🎉 Thanks for your help!

kaisalmen · 2025-01-21T20:57:03Z

All green 🎉 Thanks for your help!

Wonderful. Did you already test the release process?

kaisalmen

Let's go. We have to test this in the field. 🎉

CGNonofr · 2025-01-21T22:18:14Z

All green 🎉 Thanks for your help!

Wonderful. Did you already test the release process?

It's always hard to test that, but the only difference is the subpackage path so I hope nothing broke 🤞

kaisalmen · 2025-01-22T07:54:27Z

@CGNonofr I saw that the creation of releases failed. Can you ping me once they are available? Thank you.

github-actions · 2025-01-22T10:13:26Z

🎉 This PR is included in version 12.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

CGNonofr · 2025-01-22T10:28:36Z

@kaisalmen You were already pinged :)

kaisalmen · 2025-01-22T10:59:56Z

@CGNonofr dependency problems, see: #557

Loïc Mangeonjean added 21 commits January 20, 2025 21:20

chore: enable verbatimModuleSyntax

e36b105

doc: add missing details in doc

60b3457

fix: adapt patch to new VSCode file format

834bc6a

fix: fix xterm being importer from main

a400c24

fix: transform all VSCode const enum to regular enum

6af2398

const enums are a pain in the ass for libraries

refactor: remove hack, simplify code

c0cdf72

refactor: simplify type reference

2243c10

fix: completely rework build process

0bff8d9

- always keep d.ts near the .js - make code more maintainable - faster - fix subpackage dependencies computation

fix: update build process to handle peerDependencies

9fb1e8d

fix: make build idem deterministic

941683d

fix(demo): enable install-links to fix local dependency issues

bc21b7c

feat(demo): add update-local-dependencies script

e72b43a

chore(demo): run local dependency update script

dfde372

chore: update all dependencies

06d678a

chore: update node and npm

6e1994e

fix: typo

1ae34cd

chore: replace ts-node by tsx

fee240e

lib!: update to VSCode 1.96

841c0fc

fix: stop removing IIFEs

2bc93d6

as it breaks some namespace declarations

lib(demo): update demo local dependencies

bee38ba

chore: update eslint and use recommended config

48c8934

CGNonofr requested review from kaisalmen and CompuIves January 20, 2025 20:20

CGNonofr changed the title ~~Reword build process and update to 1.96.3~~ Rewamp build process and update to 1.96.3 Jan 21, 2025

CGNonofr force-pushed the lmn/update-vscode-1.96 branch 4 times, most recently from 9290a3b to bef41fd Compare January 21, 2025 15:08

kaisalmen mentioned this pull request Jan 21, 2025

tsWorker module build error, or can't create web workers (+ undefined warnings) TypeFox/monaco-languageclient#830

Open

Loïc Mangeonjean added 5 commits January 21, 2025 17:46

chore: eslint autofix

3a6ff68

fix: remove yarn usage

58311e2

fix: install missing dependencies

219677d

chore: regenerate package-lock

31f222c

fix: fix build of rollup plugins

9b4b750

CGNonofr force-pushed the lmn/update-vscode-1.96 branch from 124ec32 to 9b4b750 Compare January 21, 2025 16:46

CGNonofr changed the title ~~Rewamp build process and update to 1.96.3~~ Revamp build process and update to 1.96.3 Jan 21, 2025

kaisalmen approved these changes Jan 21, 2025

View reviewed changes

CGNonofr merged commit d2b1b4f into main Jan 21, 2025
2 checks passed

CGNonofr deleted the lmn/update-vscode-1.96 branch January 21, 2025 22:18

github-actions bot added the released label Jan 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revamp build process and update to 1.96.3 #555

Revamp build process and update to 1.96.3 #555

CGNonofr commented Jan 20, 2025 •

edited

Loading

CGNonofr commented Jan 20, 2025

kaisalmen commented Jan 21, 2025

kaisalmen commented Jan 21, 2025 •

edited

Loading

kaisalmen commented Jan 21, 2025 •

edited

Loading

kaisalmen commented Jan 21, 2025

CGNonofr commented Jan 21, 2025 •

edited

Loading

kaisalmen commented Jan 21, 2025 •

edited

Loading

kaisalmen commented Jan 21, 2025

CGNonofr commented Jan 21, 2025

kaisalmen commented Jan 21, 2025

CGNonofr commented Jan 21, 2025

kaisalmen commented Jan 21, 2025 •

edited

Loading

CGNonofr commented Jan 21, 2025

CGNonofr commented Jan 21, 2025 •

edited

Loading

kaisalmen commented Jan 21, 2025

kaisalmen left a comment

CGNonofr commented Jan 21, 2025

kaisalmen commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

CGNonofr commented Jan 22, 2025

kaisalmen commented Jan 22, 2025

Revamp build process and update to 1.96.3 #555

Revamp build process and update to 1.96.3 #555

Conversation

CGNonofr commented Jan 20, 2025 • edited Loading

CGNonofr commented Jan 20, 2025

kaisalmen commented Jan 21, 2025

kaisalmen commented Jan 21, 2025 • edited Loading

kaisalmen commented Jan 21, 2025 • edited Loading

kaisalmen commented Jan 21, 2025

CGNonofr commented Jan 21, 2025 • edited Loading

kaisalmen commented Jan 21, 2025 • edited Loading

kaisalmen commented Jan 21, 2025

CGNonofr commented Jan 21, 2025

kaisalmen commented Jan 21, 2025

CGNonofr commented Jan 21, 2025

kaisalmen commented Jan 21, 2025 • edited Loading

CGNonofr commented Jan 21, 2025

CGNonofr commented Jan 21, 2025 • edited Loading

kaisalmen commented Jan 21, 2025

kaisalmen left a comment

Choose a reason for hiding this comment

CGNonofr commented Jan 21, 2025

kaisalmen commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

CGNonofr commented Jan 22, 2025

kaisalmen commented Jan 22, 2025

CGNonofr commented Jan 20, 2025 •

edited

Loading

kaisalmen commented Jan 21, 2025 •

edited

Loading

kaisalmen commented Jan 21, 2025 •

edited

Loading

CGNonofr commented Jan 21, 2025 •

edited

Loading

kaisalmen commented Jan 21, 2025 •

edited

Loading

kaisalmen commented Jan 21, 2025 •

edited

Loading

CGNonofr commented Jan 21, 2025 •

edited

Loading