-
Notifications
You must be signed in to change notification settings - Fork 17
[WIP] - EN/00-01.html Dropdown Menu Select Option to Change Languages #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
47bdae4
[WIP] -- Adding Language menu for en 00-01 html
DaricusDuncan 49cb948
Modified select menu errors
DaricusDuncan 927c58c
Removed console.log
DaricusDuncan 3515cf3
Back button action resets language menu option to [Selected] option.
DaricusDuncan bf0a7e9
Moved languageMenu Code from the en/00-01.html file
DaricusDuncan ac9579b
Updated tutorial.html footer section to hold languageMenu code
DaricusDuncan 10b3404
Updated my gitignore file
DaricusDuncan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This site shall also work off-line, without any Internet connection.
This is not important now. Before I merge, I would like to make sure that a downloaded version does not load resources from other locations. This is also a privacy concern as I do not want this page to tell jquery.com that the viewer is interested in this site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niccokunzmann I can try to figure out a solution to my problem without using JQuery or using the downloaded version of JQuery.
I am still working on this issue and will be continuing the setup of Jekyll locally.
I am one trumpet out of the band here so if there is anything you just do not like, let me know and I can change it.