(breaking?) tweak zoomFactor to use camera scrolling #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the zooming effect on sprites with their zoomFactor changed looked awkward because it wasnt taking camera scroll into account yes this Will change visuals in all mods that use this property . maybe there should be a var to revert to old behavior or smth
Raltyro
requested changes
Jul 13, 2025
|
I forgot to close this in v1.0.0 release, since this is solved??? correct me if im wrong |
|
no it is not solved... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the zooming effect on sprites with their zoomFactor changed looked awkward because it wasnt taking camera scroll into account
yes this Will change visuals in all mods that use this property . maybe there should be a var to revert to old behavior or smth