Skip to content

Made combo breaks, actually be combo breaks. #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

rodney528
Copy link
Contributor

No description provided.

@crowplexus
Copy link
Member

that should also reset the combo to 0, not just increase the breaks counter

crowplexus added a commit to CodenameCrew/CodenameEngine-Dev that referenced this pull request Nov 30, 2024
@rodney528
Copy link
Contributor Author

that should also reset the combo to 0, not just increase the breaks counter

woops

@rodney528
Copy link
Contributor Author

wait

@rodney528
Copy link
Contributor Author

that happens either way

@rodney528
Copy link
Contributor Author

Why do I keep getting a notification for this? Nothings happening.

@r6915ee
Copy link

r6915ee commented Dec 2, 2024

Why do I keep getting a notification for this? Nothings happening.

It's likely a general update, I've been getting notifications where nobody replies as well.

@rodney528
Copy link
Contributor Author

Why do I keep getting a notification for this? Nothings happening.

It's likely a general update, I've been getting notifications where nobody replies as well.

Huh, good to have ig.

@NeeEoo
Copy link
Contributor

NeeEoo commented Dec 12, 2024

The combo breaks dont break, the combo counter, plus dont they count the same as misses? so why have it seperate?

@r6915ee
Copy link

r6915ee commented Dec 12, 2024

The combo breaks dont break, the combo counter, plus dont they count the same as misses? so why have it seperate?

I'd say that Combo Breaks are just stricter misses and follow the lines of an FC more.

@rodney528
Copy link
Contributor Author

The combo breaks dont break, the combo counter, plus dont they count the same as misses? so why have it seperate?

Ok, there separate because as you said, there not misses, and fuck.

@rodney528
Copy link
Contributor Author

fixed

@rodney528
Copy link
Contributor Author

rodney528 commented Dec 13, 2024

I swear I am a blind man.

@rodney528 rodney528 requested a review from NeeEoo December 13, 2024 00:12
@crowplexus crowplexus requested review from crowplexus and removed request for NeeEoo June 30, 2025 11:54
@crowplexus crowplexus added the type:enhancement New feature or request label Jun 30, 2025
@crowplexus
Copy link
Member

I'm not too sure about adding this actually, CNE isn't really a competitive engine that prioritizes competitive gameplay to have Combo Breaks, I'll let the rest of the team know, but honestly we might just remove Combo Breaks altogether

@rodney528
Copy link
Contributor Author

understandable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants