Live charting in Charter#432
Closed
THEkatinamicrowave wants to merge 47 commits intoCodenameCrew:mainfrom
Closed
Conversation
so it begins
fuck you, songposition
The notes aren't visually appearing for some reason (help)
Contributor
Author
|
Why aren't the notes appearing onscreen |
This has not been tested
I have the demonetnia
whoopsie
skibidi
noticed that it keeps playing (but not recording) after you press accept probably just a FlxG.pressed thing I'll try to fix it or I won't it's not like it's a huge bug, just a little quirk
Member
|
hmm honestly this would be cool actually, just have to check everything in the future |
Contributor
Author
yeah I'm tryna figure out how to properly create and add a charternote |
womp womp
Contributor
Author
|
@NeeEoo it's not letting me auto-update the stuff how do I make my branch utd |
Contributor
|
there |
You'll get it when you're older (check Gamejolt)
- fixed it so it follows the current format - optimized one of the bits of code
for Z X , . players
Contributor
Author
|
YOOOO IT LIKE SOMEWHAT WORKS NOW |
Contributor
Author
|
pointless; also literally has branch conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I already made en enhancement issue about this, so I'll copy and paste it here:
Ok so hear me out.
You're trying to make a chart for a song you made, except you decided to make a one-shot mod so your song is like 8 minutes long. Charting usually takes
time of song* 185323, so this idea should make charting quicker.Using a keybind like Ctrl + R, the charter will prompt you to click a strumline to select it for charting. Once selected, you can press space to begin a countdown, starting at the beginning of your chart (Ctrl + Shift + R to start at current position). During this recording, any keybinds that you press will be converted to notes (don't worry, they'll be snapped to whatever grid you set (the one that's 16 by default). Once you press Ctrl + R again, the recording is stopped and you can go in to manually edit whatever charting you didn't like.
Thought it was a cool idea and it would WAY speed up charting. Only problem I can see with this is having input delay, but you can probably easily offset the chart based on Options.songOffset.