Skip to content

Comments

Inactive volume#359

Closed
bctix wants to merge 5 commits intoCodenameCrew:mainfrom
bctix:inactive-volume
Closed

Inactive volume#359
bctix wants to merge 5 commits intoCodenameCrew:mainfrom
bctix:inactive-volume

Conversation

@bctix
Copy link
Contributor

@bctix bctix commented Jul 28, 2024

Adds the feature from osu!lazer where when the window is inactive, the volume would decrease.

I'm not sure if this is the best way to implement it, but this the best way I found trying to implementing it.

@NexIsDumb
Copy link
Member

Well it would conflict with autopause or should it ignore the option

@Jamextreme140
Copy link
Contributor

Jamextreme140 commented Aug 4, 2024

just do a check on Options.autoPause and it will work very well.

@crowplexus crowplexus added the type:enhancement New feature or request label Jun 30, 2025
@crowplexus
Copy link
Member

I'm not too sure about this one, this feels like it could be made inside a mod either way…

@crowplexus
Copy link
Member

yeah nahhhh sorryyyyyy could very well work in a mod tho…

@crowplexus crowplexus closed this Jun 30, 2025
@bctix
Copy link
Contributor Author

bctix commented Jun 30, 2025

This was made a while ago after being suggested by neo that I should make a pr after making it a soft coded addon. I totally understand if y'all don't think it's necessary to have.

@crowplexus
Copy link
Member

that's fine, i just don't think it fits the base engine (the rest of the team sort of agrees on that) though it's fine if you make an addon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants