Conversation
Member
|
Well it would conflict with autopause or should it ignore the option |
Contributor
|
just do a check on |
Member
|
I'm not too sure about this one, this feels like it could be made inside a mod either way… |
Member
|
yeah nahhhh sorryyyyyy could very well work in a mod tho… |
Contributor
Author
|
This was made a while ago after being suggested by neo that I should make a pr after making it a soft coded addon. I totally understand if y'all don't think it's necessary to have. |
Member
|
that's fine, i just don't think it fits the base engine (the rest of the team sort of agrees on that) though it's fine if you make an addon ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the feature from osu!lazer where when the window is inactive, the volume would decrease.
I'm not sure if this is the best way to implement it, but this the best way I found trying to implementing it.