chore: replace lightning-fs with memfs

memfs has FS sync methods, and we don't need actual persistence, at least for now
Codelevate-company · Nov 10, 2023 · 8583c7b · 8583c7b
1 parent 6175bc8
commit 8583c7b
Show file tree

Hide file tree

Showing 7 changed files with 259 additions and 62 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -54,7 +54,6 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "@isomorphic-git/lightning-fs": "^4.6.0",
     "assert": "^2.1.0",
     "babel-bundle": "file:./playwright/packages/playwright/bundles/babel",
     "browserify-zlib": "^0.2.0",
@@ -65,6 +64,7 @@
     "expect-bundle": "file:./playwright/packages/playwright/bundles/expect",
     "https-browserify": "^1.0.0",
     "inspector": "^0.5.0",
+    "memfs": "^4.6.0",
     "os-browserify": "^0.3.0",
     "path": "^0.12.7",
     "process": "^0.11.10",

diff --git a/src/server/crx.ts b/src/server/crx.ts
@@ -58,9 +58,9 @@ export class Crx extends SdkObject {
       protocolLogger: helper.debugProtocolLogger(),
       browserLogsCollector,
       originalLaunchOptions: {},
-      artifactsDir: '.',
-      downloadsPath: '.',
-      tracesDir: '.',
+      artifactsDir: '/crx/artifacts',
+      downloadsPath: '/crx/downloads',
+      tracesDir: '/crx/traces',
       ...options
     };
     const browser = await CRBrowser.connect(this.attribution.playwright, transport, browserOptions);