Skip to content

Conversation

@idoo
Copy link
Contributor

@idoo idoo commented Jul 24, 2019

No description provided.

@idoo idoo changed the title feat: support for multiline comment for languages that use default regex feat: support for multiline comment for languages that use JS regex Jul 24, 2019
@Bogdan-Lyashenko
Copy link
Collaborator

@idoo I tested, it seems like something wrong with parsing. See screenshot from redux-state for codecrumb; pls check what's happing inside parseCodecrumbComment
image

@Bogdan-Lyashenko
Copy link
Collaborator

@idoo multiple crumbs in one file don't work. e.g. add //cc:signin#8 to example-project/src-client/auth/actions.js

return [];
}

const result = fileCode.match(regex) || [];
Copy link
Collaborator

@Bogdan-Lyashenko Bogdan-Lyashenko Aug 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idoo match returns more than you need :)
if you run yarn server:two it will look like this
image
while in master it's like this
image
you can see there is an issue with example-project/src-server/app/service/user/session.py

Match returns

[ '#cc:signin#3;updare seesion',
  '',
  'cc:signin#3;updare seesion',
  index: 0,
  input: '#cc:signin#3;updare seesion' ]

there, so after filter by //cc you gonna have double '#cc:signin#3;updare seesion'

@idoo idoo force-pushed the feature/multiline branch from ffc37b9 to cb823d9 Compare August 5, 2019 09:44
@idoo idoo force-pushed the feature/multiline branch from 662479c to ac772b3 Compare August 22, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants