-
Couldn't load subscription status.
- Fork 105
feat: support for multiline comment for languages that use JS regex #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@idoo I tested, it seems like something wrong with parsing. See screenshot from redux-state for codecrumb; pls check what's happing inside |
|
@idoo multiple crumbs in one file don't work. e.g. add |
| return []; | ||
| } | ||
|
|
||
| const result = fileCode.match(regex) || []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idoo match returns more than you need :)
if you run yarn server:two it will look like this

while in master it's like this

you can see there is an issue with example-project/src-server/app/service/user/session.py
Match returns
[ '#cc:signin#3;updare seesion',
'',
'cc:signin#3;updare seesion',
index: 0,
input: '#cc:signin#3;updare seesion' ]
there, so after filter by //cc you gonna have double '#cc:signin#3;updare seesion'
662479c to
ac772b3
Compare

No description provided.